joomla-cms icon indicating copy to clipboard operation
joomla-cms copied to clipboard

Convert mod_messages to service provider

Open joomlaweby opened this issue 1 year ago • 6 comments

Summary of Changes

Converts the messages administrator module to service provider.

This is my first pull request to Joomla! project :-).

Testing Instructions

  1. Make sure you have administrator component com_messages (Private Messages) and module mod_messages enabled
  2. Make sure you have at least 1 unread message
  3. You should see module output

mod_messages

Actual result BEFORE applying this Pull Request

Module works as expected

Expected result AFTER applying this Pull Request

Module works same way as before applying pull request

Link to documentations

Please select:

  • [ ] Documentation link for docs.joomla.org:

  • [X] No documentation changes for docs.joomla.org needed

  • [ ] Pull Request link for manual.joomla.org:

  • [X] No documentation changes for manual.joomla.org needed

joomlaweby avatar Jan 30 '24 19:01 joomlaweby

I have tested this item :white_check_mark: successfully on 24ba818c9029e80a37bcfa919a98b8c2173175f8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42735.

fgsw avatar Feb 03 '24 10:02 fgsw

@joomlaweby No need to update your branch when there are no conflicts shown. Updating the branch in validates the test counter for human test. I've restored the result from @fgsw now so it's counted again.

richard67 avatar Feb 11 '24 16:02 richard67

@joomlaweby No need to update your branch when there are no conflicts shown. Updating the branch in validates the test counter for human test. I've restored the result from @fgsw now so it's counted again.

@richard67 OK, got it. :-)

joomlaweby avatar Feb 11 '24 16:02 joomlaweby

I have tested this item :white_check_mark: successfully on 769c4abc039e809dbd7ccbc0defc8780f53bfdc0


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42735.

viocassel avatar Feb 22 '24 16:02 viocassel

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42735.

richard67 avatar Feb 22 '24 17:02 richard67

Tested successfully during PBF 2024.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42735.

exlemor avatar Feb 24 '24 16:02 exlemor

Thank you @joomlaweby and also for testing and support @fgsw @viocassel @exlemor @richard67 @sandewt

LadySolveig avatar Feb 27 '24 00:02 LadySolveig