joomla-cms icon indicating copy to clipboard operation
joomla-cms copied to clipboard

Change the getItem return type to stdClass and make the CMSObject inherit it

Open laoneo opened this issue 1 year ago • 3 comments
trafficstars

Summary of Changes

To get away from the CMSObject class we need a step by step process in the getItem function of the admin model. Alternative to #42714 which makes the CMSObject a stdClass and changes the return type to it. It is a more lightweight solution as no new deprecated flag is introduced. It has basically the same effect as when we change the flag in 6.0.

Testing Instructions

Create an article in the back end. With as many content plugins as possible.

Actual result BEFORE applying this Pull Request

All works.

Expected result AFTER applying this Pull Request

All works.

Link to documentations

Please select:

  • [ ] Documentation link for docs.joomla.org:

  • [ ] No documentation changes for docs.joomla.org needed

  • [ ] Pull Request link for manual.joomla.org:

  • [ ] No documentation changes for manual.joomla.org needed

laoneo avatar Jan 27 '24 06:01 laoneo

I have tested this item :white_check_mark: successfully on 080cca9abe134c034cde296f0152b8b88a8fef7f

I've created an article with a number of custom fields and schema stuff. No difference before / after patch so I guess it works.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42717.

crommie avatar Feb 24 '24 11:02 crommie

I have tested this item :white_check_mark: successfully on 080cca9abe134c034cde296f0152b8b88a8fef7f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42717.

viocassel avatar Feb 24 '24 14:02 viocassel

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42717.

richard67 avatar Feb 24 '24 14:02 richard67

Thank you @laoneo and also for testing @crommie and @viocassel

LadySolveig avatar Feb 27 '24 10:02 LadySolveig