joomla-cms icon indicating copy to clipboard operation
joomla-cms copied to clipboard

[5.x] Localize own package

Open dgrammatiko opened this issue 1 year ago • 5 comments
trafficstars

Pull Request for Issue # .

Summary of Changes

  • Localise my own gzip package @dgrammatiko/compress

Testing Instructions

Check out this PR

  • run npm i
  • run npm gzip

Check that the gzipped files inside the media folder are created Rename the htaccess.txt and check if the gzipped files are loading correctly

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

  • [ ] Documentation link for docs.joomla.org:

  • [x] No documentation changes for docs.joomla.org needed

  • [ ] Pull Request link for manual.joomla.org:

  • [x] No documentation changes for manual.joomla.org needed

dgrammatiko avatar Nov 29 '23 18:11 dgrammatiko

I have tested this item :white_check_mark: successfully on 918bb2c742bda2cfe61038468a6dc2ca665443e1

Gzip files are created. Website loads OK. I had to run 'composer install' after checkout. Then 'npm ci', then 'npm run gzip' (not npm gzip). Turned on 'Gzip Page Compression' in Global Configuration, Server Tab. Check Requests to js or css in Browser debug page. Content-Encoding must be gzip.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42428.

MacJoom avatar Dec 05 '23 20:12 MacJoom

I have tested this item :white_check_mark: successfully on 918bb2c742bda2cfe61038468a6dc2ca665443e1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42428.

viocassel avatar Jan 15 '24 21:01 viocassel

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42428.

richard67 avatar Jan 16 '24 19:01 richard67

@bembelimen @HLeithner Is this PR ok for 5.0-dev? Or should it be rebased to 5.1-dev?

richard67 avatar Jan 16 '24 19:01 richard67

5.1 please

HLeithner avatar Jan 17 '24 07:01 HLeithner

Thank you @dgrammatiko and also for testing @MacJoom @viocassel

LadySolveig avatar Mar 02 '24 16:03 LadySolveig