joomla-cms icon indicating copy to clipboard operation
joomla-cms copied to clipboard

[5.1] com_contact remove showon when useglobal is used in the field

Open drmenzelit opened this issue 1 year ago • 8 comments

Pull Request for Issue #42381 .

Summary of Changes

Removed the showon option in several fields

Testing Instructions

See issue #42381

Actual result BEFORE applying this Pull Request

Showon fields are not displayed in contact and menu item if the "parent" field has useglobal

Expected result AFTER applying this Pull Request

Showon fields are displayed

Link to documentations

Please select:

  • [ ] Documentation link for docs.joomla.org:

  • [x] No documentation changes for docs.joomla.org needed

  • [ ] Pull Request link for manual.joomla.org:

  • [x] No documentation changes for manual.joomla.org needed

drmenzelit avatar Nov 22 '23 19:11 drmenzelit

maybe it's better to fix the real issue if the issue is true for all global based showOns ?

HLeithner avatar Nov 23 '23 08:11 HLeithner

maybe it's better to fix the real issue if the issue is true for all global based showOns ?

Yes ;-) useglobal inserts a new select option but without value ... do you know where that is created?

drmenzelit avatar Nov 23 '23 10:11 drmenzelit

I have tested this item :white_check_mark: successfully on 441e2f167ccd0f2d7db4a7d9c992b8ce1a34e2e3


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42386.

crimle avatar Apr 05 '24 17:04 crimle

I have tested this item :white_check_mark: successfully on 441e2f167ccd0f2d7db4a7d9c992b8ce1a34e2e3

Tested on 5.1.0 RC1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42386.

MacJoom avatar Apr 05 '24 17:04 MacJoom

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42386.

Quy avatar Apr 05 '24 18:04 Quy

I have tested this item :white_check_mark: successfully on a80245dbdf6d525942a083a494749ff727849ae1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42386.

cybersalt avatar Apr 11 '24 21:04 cybersalt

Back to pending


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42386.

bembelimen avatar May 11 '24 20:05 bembelimen

Like Harald said, removing the option does not fix the issue: #42386 (comment)

I was not able to find the code for that ... https://github.com/joomla/joomla-cms/pull/42386#issuecomment-1824108867

drmenzelit avatar May 12 '24 17:05 drmenzelit

This PR doesn't solve the underlying problem of showon fields. We need more coding effort for that.

drmenzelit avatar May 15 '24 17:05 drmenzelit