joomla-cms
joomla-cms copied to clipboard
[5.1] Convert mod_feed to service provider
Summary of Changes
Converts the feed site module to service provider
Testing Instructions
- create site module
feed
- check site output
Note: system test added
Actual result BEFORE applying this Pull Request
module works
Expected result AFTER applying this Pull Request
module works
Link to documentations
Please select:
- [x] No documentation changes for docs.joomla.org needed
- [x] No documentation changes for manual.joomla.org needed
I have tested this item :white_check_mark: successfully on c7773b90a0424105b6b7b509c62b30acec4cd47a
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42215.
I have tested this item :white_check_mark: successfully on 9e552c8a13254f0b6f85380c4521f9f0443cf491
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42215.
I have tested this item :white_check_mark: successfully on 9e552c8a13254f0b6f85380c4521f9f0443cf491
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42215.
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42215.
Thank you!
Still one more comment, see file: modules/mod_feed/src/Helper/FeedHelper.php
line 65: deprecated DEPLOY_VERSION will be removed in 7.0
I expected, just like with other recent PRs, eg #42792 deprecated DEPLOY_VERSION will be removed in 6.0
Is there a reason for that?