joomla-cms icon indicating copy to clipboard operation
joomla-cms copied to clipboard

[5.1] Convert mod_feed to service provider

Open heelc29 opened this issue 1 year ago • 4 comments

Summary of Changes

Converts the feed site module to service provider

Testing Instructions

  • create site module feed
  • check site output

Note: system test added

Actual result BEFORE applying this Pull Request

module works image

Expected result AFTER applying this Pull Request

module works image

Link to documentations

Please select:

  • [x] No documentation changes for docs.joomla.org needed
  • [x] No documentation changes for manual.joomla.org needed

heelc29 avatar Oct 24 '23 16:10 heelc29

I have tested this item :white_check_mark: successfully on c7773b90a0424105b6b7b509c62b30acec4cd47a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42215.

ceford avatar Oct 27 '23 07:10 ceford

I have tested this item :white_check_mark: successfully on 9e552c8a13254f0b6f85380c4521f9f0443cf491


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42215.

viocassel avatar Jan 16 '24 09:01 viocassel

I have tested this item :white_check_mark: successfully on 9e552c8a13254f0b6f85380c4521f9f0443cf491


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42215.

crimle avatar Feb 24 '24 14:02 crimle

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42215.

richard67 avatar Feb 24 '24 14:02 richard67

Thank you!

bembelimen avatar Feb 27 '24 23:02 bembelimen

Still one more comment, see file: modules/mod_feed/src/Helper/FeedHelper.php

line 65: deprecated DEPLOY_VERSION will be removed in 7.0

I expected, just like with other recent PRs, eg #42792 deprecated DEPLOY_VERSION will be removed in 6.0

Is there a reason for that?

sandewt avatar Feb 28 '24 08:02 sandewt