joomla-cms icon indicating copy to clipboard operation
joomla-cms copied to clipboard

Fix Joomla.renderMessages not found with mod_login

Open Fedik opened this issue 2 years ago • 4 comments

Pull Request for Issue #41299 .

Summary of Changes

Add missing dependency for Joomla.renderMessages

Testing Instructions

Please follow #41299

Actual result BEFORE applying this Pull Request

JS error

Expected result AFTER applying this Pull Request

No error

Link to documentations

Please select:

  • [x] No documentation changes for docs.joomla.org needed
  • [x] No documentation changes for manual.joomla.org needed

Fedik avatar Aug 01 '23 15:08 Fedik

I can't reproduce this problem. I have Multi-factor Authentication is not enabled. I have registered my Authenticator in W3C Web Authentication (WebAuthn) Login. In the Admin login form I click the button on the dongle when prompted and login works normally. With a user not using that method there is a normal error message. Everything I see is translated. I do not see any Javascript error messages.

Perhaps some more specific test instructions would help. I am using joomla-cms with 4.3-dev checked out and Chrome/Firefox on Mac.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41300.

ceford avatar Sep 25 '23 10:09 ceford

Same with frontend login - no problems.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41300.

ceford avatar Sep 25 '23 11:09 ceford

This pull request has been automatically rebased to 4.4-dev.

HLeithner avatar Sep 30 '23 22:09 HLeithner

I have tested this item :red_circle: unsuccessfully on e67eb169c50081d100c7bf18a141fe6b10f379ca

Could not reproduce the Javascript error in the console on failed login. My method: Create user with a valid webauthn setup. Check that login works for this user on the front-end using the mod_login form. Log the user out in front-end. Remove the webauthn setup for this user. Reload page. Try to login again as webauth for this user. No Javascript errors in console. Only an formatted error message is displayed: "The credential ID is invalid." So It is rendering the message just fine. Joomla 4.4.3


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41300.

TLWebdesign avatar Feb 24 '24 11:02 TLWebdesign