[5.2] Move language autoload out from CMSPlugin constructor

[Fedik]

Summary of Changes

Alernative to #40309 The patch moves language loading out from CMSPlugin constructor. This makes the constructor lighter and probably esier for tests, also allows to restore #27155.

Testing Instructions

Apply patch, and make sure all works as before. All plugins translated.

Link to documentations

Please select:

• [ ] Documentation link for docs.joomla.org: IDK
• [ ] No documentation changes for docs.joomla.org needed
• [ ] No documentation changes for manual.joomla.org needed
• [ ] Pull Request link for manual.joomla.org: IDK

[HLeithner]

I think it's not a good idea to force the application in the plugin to load the languages, wouldn't it be better to provide the language in the register process?

[Fedik]

Accessing language in constructor of the System plugins should be forbiden (and for any other group also). Because the Language available not early than afterInitialise. That will limit the plugin usage, and will not allow to use it for early stages. And this is a main reason why I tries to move language loading out from constructor ;)

[ceford]

I have tested this item :white_check_mark: successfully on 2bf60900c062f9c38b9a91eb8420c1659bcb5f88

I applied patch, logged in with German selected and opened several plugins - all strings were in German. Is that a valid test?

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40355.}

[HLeithner]

I'm not so happy to merge this in to 5.0 anymore, since it would effect existing plugins depending for the loaded language in the constructor. I think we have to postpone this to 6.0 or find a better b/c way.

[Fedik]

Yeah, it would be need before first alpha :)

But I thinking to moving it in to bootPlugin(), will be smarter.

if ($plugin->autoloadLanguage()) {
  ... here some code for checking if language is ready, then:  
  $plugin->loadLanguage();
}

For 6 or maybe can get in one of 5.x. Loading language in the plugin constructor is very bad.

[HLeithner]

This pull request has been automatically rebased to 5.1-dev.

[Fedik]

I have changed approach, should be better now.

[HLeithner]

This pull request has been automatically rebased to 5.3-dev.