joomla-cms icon indicating copy to clipboard operation
joomla-cms copied to clipboard

[5.1] Menus and categories view with equal headline

Open chmst opened this issue 2 years ago • 27 comments

Pull Request for Issue # .

Summary of Changes

Make headline in categories like headline in menus. There is plenty of place for text and is better a11y and usability.

Testing Instructions

Compare menus and categories view in backend

Actual result BEFORE applying this Pull Request

grafik

grafik

Expected result AFTER applying this Pull Request

grafik

chmst avatar Sep 20 '22 10:09 chmst

If this change is going to be made thn it needs to be made everywhere - I know of at least banners-clients that would also need to be updated - there may be others.

Also its not a bug fix so it should be in 4.3 i think

brianteeman avatar Sep 20 '22 12:09 brianteeman

agree. Do you see any problems there? It is better UX and better a11y.

chmst avatar Sep 20 '22 14:09 chmst

Not sure myself that it's better anything, but it must be at least consistent

brianteeman avatar Sep 20 '22 14:09 brianteeman

I think this is definitely more clear, at least in desktop. What happens in mobile?

consistency is of course important, but let's figure out the best pattern and then we can see where else it needs to be implemented. :)

crystalenka avatar Sep 20 '22 14:09 crystalenka

Ithas to be made equal for all categories. Now we havean inconsitency. Why I prefer this versoin? Because we make text invisible when there is plenty of place, no need for ugly titles. The dropdown for hiding columns says "archived items" - is it obvious that the folder icon stands for archived items? You know that of course - but a new user?

chmst avatar Sep 20 '22 14:09 chmst

@crystalenka on mobile these columns are not displayed at all.

chmst avatar Sep 20 '22 18:09 chmst

will you be updating banner-clients?

brianteeman avatar Sep 20 '22 19:09 brianteeman

There are all categories views - banner, newsfeed, contacts (also weblinks). Maybe user notes .. I must investigate.

If the pattern is accepted then I can do it (but after my holidays). I can set this on draft, so nothing happens befor all is consistent.

chmst avatar Sep 20 '22 19:09 chmst

There are all categories views - banner, newsfeed, contacts (also weblinks). Maybe user notes .. I must investigate.

I checked them

brianteeman avatar Sep 20 '22 19:09 brianteeman

I have tested this item :white_check_mark: successfully on c82adbf251d90757b4f0830f948cc5e7ea668a81

Tested this successfully, thank you!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38787.

coolcat-creations avatar Oct 25 '22 08:10 coolcat-creations

Tested successfully, but not submitting it on the tracker because I am reconsidering my earlier comment after seeing it in different components. :/

The labels are indeed more clear than only icons, but I am currently on my laptop which has a smaller screen and in some components, this change means that there is significantly less white space and a lot of visual weight is given to these counters when they're not necessarily the most critical part of these views:

Banners: Clients screen Smart search: content maps Articles: categories

As a result, even though the labels are more clear, the interface is harder to understand because the eye doesn't know where to go.

I agree both that the original pattern isn't very clear and that it should be consistent across all views like this, but I think we need to take a step back and find a different approach so it can be both clear and meaningful.

I was wrong before to make an opinion without seeing how it affected other components; apologies that you spent additional time on it just for me to come in and suggest a different direction. :(

crystalenka avatar Oct 25 '22 10:10 crystalenka

@crystalenka thats why they were not given heading texts originally. It would be good if people remembered that previous work was not done on a whim without any thought.

brianteeman avatar Oct 25 '22 10:10 brianteeman

@crystalenka thats why they were not given heading texts originally. It would be good if people remembered that previous work was not done on a whim without any thought.

No one implied that. Previous work is important; we also need to be open to improving and getting better as we learn and grow. I think there is a solution that solves both problems but need to think through it more.

crystalenka avatar Oct 25 '22 10:10 crystalenka

The smart search content map was not changed in this PR. I would remove the "indexed content" from the language string. I can do that if you want.

In any case, these informations should be consistent. We have

  • the "verbose" version in com_menus
  • the "very verbose" version in smart search
  • the "icons only" in categories and banners

So we were not consequent in the past.

But if the JXT wants to make a concept which meets all needs, I will be happy. Maybe a separator or very light background could make it better.

chmst avatar Oct 25 '22 10:10 chmst

Maybe add a legend in the footer similar to Permissions.

legend

Quy avatar Jan 26 '23 16:01 Quy

I have tested this item :white_check_mark: successfully on 462b155983dcdf2fd4bed720194d12890c448c6d

I have tested this item ✅ successfully


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38787.

dennise24 avatar Feb 24 '24 10:02 dennise24

I have tested this item :white_check_mark: successfully on 462b155983dcdf2fd4bed720194d12890c448c6d

I have tested this item ✅ successfully


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38787.

hannazn avatar Feb 24 '24 10:02 hannazn

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38787.

richard67 avatar Feb 24 '24 10:02 richard67

I have tested this item :red_circle: unsuccessfully on 462b155983dcdf2fd4bed720194d12890c448c6d

Got an error: 500 Layout default_batch_footer not found.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38787.

https://prnt.sc/s257iDiogD3c

peterpeter avatar Feb 24 '24 10:02 peterpeter

I have tested this item :red_circle: unsuccessfully on 462b155983dcdf2fd4bed720194d12890c448c6d

Error in Articles Categories after installation An error has occurred. 500 Layout default_batch_footer not found.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38787.

dorisdreher avatar Feb 24 '24 11:02 dorisdreher

I have not tested this item.

In Safari 15.6.1 I don't see the difference


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38787. Schermata 2024-02-24 alle 12 08 04

adj9 avatar Feb 24 '24 11:02 adj9

I have tested this item :red_circle: unsuccessfully on 462b155983dcdf2fd4bed720194d12890c448c6d

I tested the patch with 5.1.0-alpha1 and ‎5.1.0-alpha4 and I encountered the following error:

An error has occurred. 500 Layout default_batch_footer not found.

image


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38787.

robertolongo avatar Feb 24 '24 11:02 robertolongo

To all who get the error "500 Layout default_batch_footer not found.": How have you applied the pull request and on which Joomla version? That layout has been removed in 5.1 meanwhile.

I will trigger a new build of the testing packages for download right now. Maybe they were not up to date with that change.

You can test again when the downloads are available again.

richard67 avatar Feb 24 '24 11:02 richard67

I have tested this item :white_check_mark: successfully on 462b155983dcdf2fd4bed720194d12890c448c6d

good work


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38787.

faustonenci avatar Feb 24 '24 11:02 faustonenci

@richard67 Joomla 5.1.0-alpha4 with pre-installed com_patchtester from server list on pizza-bugs-fun.com


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38787.

peterpeter avatar Feb 24 '24 11:02 peterpeter

I have tested this item :white_check_mark: successfully on 77281dfad593dabf51ae0402c66c0ec6f02a9671

@peterpeter @dorisdreher After the drone rebuilder, it works!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38787.

robertolongo avatar Feb 24 '24 13:02 robertolongo

I have tested this item :white_check_mark: successfully on 77281dfad593dabf51ae0402c66c0ec6f02a9671

Works now :smile:


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38787.

peterpeter avatar Feb 24 '24 13:02 peterpeter

Thank you!

LadySolveig avatar Mar 02 '24 16:03 LadySolveig

@chmst @LadySolveig The tooltip in the category view only applies to articles and is confusing for all other category views. image

heelc29 avatar Mar 03 '24 09:03 heelc29

Confirmed that the changes in this PR are not correct - obviouslty the same problem is present with banners

brianteeman avatar Mar 03 '24 09:03 brianteeman