joomla-cms
joomla-cms copied to clipboard
Better descriptor of what the "Keyboard shortcut" shortcut does
Pull Request for Issue # .
Summary of Changes
Changes "Keyboard Shortcuts" text shown at bottom of admin to "Show keyboard shortcuts"
Testing Instructions
Check bottom of admin panel showing the "Keyboard Shortcuts" apply patch Check that it has changed.
Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Documentation Changes Required
if used then Update user documentation showing the change in verbiage.
Less is more - this change adds nothing
Less is more - this change adds nothing
Your welcome to your opinion.
Not just mine
github

gmail

tweetdeck

facebook

if your going to post examples the be relevant and accurate. Others ineptness at the English language is not my fault.
as FB clearly shows, their shortcut is labeled in such a way to in imply its going to a legend. They simply chose different verbiage.

anyway, I'm not going to continue to have a battle of wits with an unarmed opponent.
if your going to post examples the be relevant and accurate. Others ineptness at the English language is not my fault.
You submitted a pull request for review and I have offered my review. You didn't provide any evidence that it is better to be overly verbose or that users have been confused about what the expected behaviour is. It is well documented that less is more when it comes to onscreen information and it's included in the style guide. Not every proposed change is an improvement and we all see contributions rejected at some time or other.
There is no need for personal attacks.
Btw. The description of J + X is misleading. Because suggest using click together. Should be J -> X or J and X (not together).
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38755.
There is a pull request already for that
I have tested this item :white_check_mark: successfully on 203f8e4c07a22147592b12b1240c81405c2dfc07
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38755.
I like the "Show keyboard shortcuts". But I think the headline should be only "Joomla Short Cuts"

please update the original post
please use capitalisation on the title
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38755.
Everyone should be happy now. It's been redone correctly. Sorry I made mistakes in it before.
I have tested this item ✅ successfully on 203f8e4
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38755.
needs retesting due to errors on my part
I assume that you will be updating h rest of jomla with this useless extra word eg Show Help, Show Options Show Articles etc
I assume that you will be updating h rest of jomla with this useless extra word eg Show Help, Show Options Show Articles etc
Who is the one who stated personal attacks were unwarranted?
not a personal comment its a statement of fact. If we add the useless word here then we have to also add the useless word in all similar use cases.
Well, being I'm not one of the dev's who created it, when I first saw it my thoughts were... hmmm what in the world is this? click OH!.. why didn't it tell me that? so, I'm probably not the only one who feels/thinks that way.
When I first saw it, I thought that I must activate the short cuts here :D.
I give up. It's ok for others to make changes but not me.