joomla-cms icon indicating copy to clipboard operation
joomla-cms copied to clipboard

[4.3] Batch Copy & Move tags

Open brianteeman opened this issue 2 years ago • 4 comments

Pull Request for Issue #23304 .

Summary of Changes

Solves a four year old feature request ;)

Adds the ability to copy and move tags

https://user-images.githubusercontent.com/1296369/186410752-c120430b-35cf-40fe-ba92-0a713b3d827a.mp4

Its a new feature so its against the 4.3 branch

Testing Instructions

It requires the tag alias bug fix from #38576 It contains an updated javascript so run npm build:js

See video

brianteeman avatar Aug 24 '22 11:08 brianteeman

I'm not making the requested changes. It makes no sense to me to have two different code styles for identical code. When phpcs finally detects these things then it can automatically do it.

brianteeman avatar Aug 24 '22 20:08 brianteeman

I'm not making the requested changes. It makes no sense to me to have two different code styles for identical code. When phpcs finally detects these things then it can automatically do it.

Ok. I'll delete the comments for short array syntax and null coalescing. But what about the changes with getCurrentUser?. Here the other components have been adjusted in 4.3-dev.

heelc29 avatar Aug 24 '22 20:08 heelc29

But what about the changes with getCurrentUser?. Here the other components have been adjusted in 4.3-dev.

Yes that one makes sense and I have accepted the change

brianteeman avatar Aug 24 '22 21:08 brianteeman

Updating branch to retrigger drone

brianteeman avatar Aug 26 '22 22:08 brianteeman

Updating branch to restart the broken drone

brianteeman avatar Oct 21 '22 17:10 brianteeman

update array code style

brianteeman avatar Mar 01 '23 10:03 brianteeman

This pull request has been automatically rebased to 5.0-dev. No new features will be merged into Joomla! 4.3 series. Joomla! 4.4 series is a bridge release to make migration from Joomla! 4 to 5 as smooth as possible.

HLeithner avatar May 08 '23 15:05 HLeithner

No video so can't test.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38583.

ceford avatar Sep 15 '23 13:09 ceford

No video so can't test.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38583.

look on github !!

brianteeman avatar Sep 15 '23 13:09 brianteeman

I tried to download the prebuilt package by clicking Details link but it results in a "Not found" error.

beni71 avatar Sep 24 '23 11:09 beni71

PR is too old, New link will be created shortly

HLeithner avatar Sep 24 '23 11:09 HLeithner

I tried to test it by installing the full package from download > Details link. But in the batch popup the new field is missing. (I'm testing with super user rights). When I debug it, the following layout

<?php echo LayoutHelper::render('joomla.html.batch.tagcopymove', []); ?>

could not be found (does not exist). Shouldn't it be here: /layouts/joomla/html/batch/tagcopymove.php

beni71 avatar Sep 24 '23 14:09 beni71

I have tested this item :red_circle: unsuccessfully on d62ae9aa452a391353ad3ba9b25d32c13f39fa7d

See my comment above.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38583.

beni71 avatar Sep 24 '23 14:09 beni71

feel free to submit a pr to fix anything you see to my branch. I wrote this 13 months ago for joomla 4.3 and I dont really have the time to dig back into the code myself to look at the changes for this

brianteeman avatar Sep 24 '23 15:09 brianteeman

closed see #41927

brianteeman avatar Sep 26 '23 06:09 brianteeman