joomla-cms icon indicating copy to clipboard operation
joomla-cms copied to clipboard

[4.3] Deprecate Joomla\CMS\Schema\ChangeItem\SqlsrvChangeItem for 5.0

Open richard67 opened this issue 2 years ago • 1 comments

Pull Request for https://github.com/joomla/joomla-cms/pull/38405#pullrequestreview-1066493530 .

Summary of Changes

Deprecate the SqlsrvChangeItem class which was used by the database checker in Joomla 3 for checking the schema on MS SQL Server databases and which will be removed in Joomla 5 with PR #38405 .

Testing Instructions

Code review.

Actual result BEFORE applying this Pull Request

The SqlsrvChangeItem class which is already useless in J4 is not marked as deprecated.

Expected result AFTER applying this Pull Request

The SqlsrvChangeItem class which is already useless in J4 is marked as deprecated.

Documentation Changes Required

None. It is already documented that Joomla 4 does not support running with a MS SQL Server database.

richard67 avatar Aug 09 '22 14:08 richard67

I have tested this item :white_check_mark: successfully on deae51d11b8a2b778cd652dadc12fa3745d549bb


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38428.

Abernyte-Git avatar Aug 09 '22 14:08 Abernyte-Git

I have tested this item :white_check_mark: successfully on deae51d11b8a2b778cd652dadc12fa3745d549bb


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38428.

viocassel avatar Aug 12 '22 07:08 viocassel

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38428.

alikon avatar Aug 12 '22 09:08 alikon

Thanks

sdwjoomla avatar Aug 13 '22 15:08 sdwjoomla

Thanks.

richard67 avatar Aug 13 '22 15:08 richard67