joomla-cms icon indicating copy to clipboard operation
joomla-cms copied to clipboard

[4.2] contacts - Indicate if category not published

Open brianteeman opened this issue 3 years ago • 3 comments

Summary of Changes

  1. Adds an indicator if the category is unpublished or trashed.
  2. Changes the published icon to a disabled icon and adds a tooltip to the icon
  3. changes to use the publishedbutton and featuredbutton

Testing Instructions

Create a category called test and create 4 featured contacts in that category. Unpublish or Trash the category

Check the list of contacts

Actual result BEFORE applying this Pull Request

No indication that the contact can not be displayed

Expected result AFTER applying this Pull Request

Text as shown in the image below

image

brianteeman avatar Apr 24 '22 11:04 brianteeman

I have tested this item :red_circle: unsuccessfully on a959bef35422e1ba664a6bea4cd535109b4c8b8c

Tested in Joomla 4.2.0-alpha3-dev of 30 April.

Thrashed the category and the contact list http://joomla42/administrator/index.php?option=com_contact&view=contacts shows the contacts as Published, Category: Test (Trashed). When each contact is checked through administrator/index.php?option=com_contact&view=contact&layout=edit&id=1, each contact is shown Published but belonging to the category Uncategorised.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37631.

toivo avatar Apr 30 '22 07:04 toivo

Thrashed the category and the contact list http://joomla42/administrator/index.php?option=com_contact&view=contacts shows the contacts as Published, Category: Test (Trashed).

So that is the correct and expected behaviour of this pr

When each contact is checked through administrator/index.php?option=com_contact&view=contact&layout=edit&id=1, each contact is shown Published but belonging to the category Uncategorised.

That is beyond the scope of this PR. This PR is only for the list view

brianteeman avatar Apr 30 '22 07:04 brianteeman

This pull requests has been automatically converted to the PSR-12 coding standard.

joomla-bot avatar Jun 27 '22 20:06 joomla-bot

This pull request has been automatically rebased to 5.0-dev.

HLeithner avatar May 02 '23 16:05 HLeithner