joomla-cms icon indicating copy to clipboard operation
joomla-cms copied to clipboard

[4.x] Filter articles in admin module mod_latest by workflow stage

Open magnussinger opened this issue 2 years ago • 14 comments

Pull Request for Issue #36802

Summary of Changes

In the backends latest articles module, one can now filter by active stages from the workflows of the respective articles

Testing Instructions

Create multiple articles with different stages of workflows, then edit the module to filter certain stages

Actual result BEFORE applying this Pull Request

You were not able to filter by stages

Expected result AFTER applying this Pull Request

You are now able to filter by workflow stage

Documentation Changes Required

None

magnussinger avatar Mar 25 '22 00:03 magnussinger

@MagnusSinger hey! here it says that this branch is out-of-date with the base branch so is the issue still open and if yes can I work on this ?

teekhandekar avatar Mar 26 '22 04:03 teekhandekar

Hi @teekhandekar, you can always work on any issue if you want, and you don't need to ask for it. But in this case, I just had to merge the base branch into my branch, so it wasn't much to do.

magnussinger avatar Mar 26 '22 07:03 magnussinger

@MagnusSinger can you rebase the pr to the 4.2-dev branch as it is a new feature?

laoneo avatar Mar 28 '22 08:03 laoneo

Sure

magnussinger avatar Mar 28 '22 09:03 magnussinger

Sorry but this is not correct.

  1. Instead of the sql field why not use the existing workflowstage field type. This has numerous advantages especially when there is more that one workflow on the site
  2. You are not checking to see if the site is using workflows before display the stage field

brianteeman avatar May 06 '22 17:05 brianteeman

This pull requests has been automatically converted to the PSR-12 coding standard.

joomla-bot avatar Jun 27 '22 21:06 joomla-bot

This pull request has been automatically rebased to 5.0-dev.

HLeithner avatar May 02 '23 16:05 HLeithner

I have tested this item ✅ successfully


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37366.

web54 avatar Aug 26 '23 13:08 web54

I have tested this item :white_check_mark: successfully on b260e85c0cb2a67bd11592c9ae7f3bcd72d65f3f

Tested on ‎5.0.0-beta1-dev PBF


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37366.

TLWebdesign avatar Aug 26 '23 14:08 TLWebdesign

With the patch applied I see a string key as may only choice: <option value="1">COM_WORKFLOW_BASIC_STAGE</option> in the Stage filter field.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37366.

ceford avatar Sep 15 '23 14:09 ceford

This pull request has been automatically rebased to 5.1-dev.

HLeithner avatar Sep 30 '23 22:09 HLeithner

Tested the issue successfully ✅

hannazn avatar Feb 24 '24 09:02 hannazn

I have tested this item ✅ successfully

dennise24 avatar Feb 24 '24 09:02 dennise24

Tested this on Joomla 5.1 alpha 4 There is no option to select no workflow. The first workflow stage in the list automatically selected. There's a translation issue with com_workflow_basic_stage. workflow stages in module

stimpsonjcat avatar Feb 24 '24 11:02 stimpsonjcat

This pull request has been automatically rebased to 5.2-dev.

HLeithner avatar Apr 24 '24 09:04 HLeithner