joomla-cms icon indicating copy to clipboard operation
joomla-cms copied to clipboard

[4.1] Make it Optional to Save Response from the GET Request Task Routine

Open ditsuke opened this issue 3 years ago • 1 comments
trafficstars

Addresses a concern from #36201.

Summary of Changes

  • Saving responses from the GET Request is now optional and disabled by default.
  • The saved result now uses the tmp_dir from the global configuration.

Testing Instructions

  • Make a task G1 with the GET Request routine, keep "Save Response" disabled.
  • Make another task G2 with "Save Response" enabled.
  • Trigger the tasks either by waiting or by manually running from the list view.

Actual result BEFORE applying this Pull Request

  • There is no option to not save the response.
  • Response is saved in the tmp/ directory blind to the tmp_dir configuration.

Expected result AFTER applying this Pull Request

  • There is an option to not save the response making retention opt-in. Response for the G1 task is not saved while response for the G2 task is saved.
  • tmp_dir configuration is respected.

Documentation Changes Required

nil

ditsuke avatar Feb 03 '22 06:02 ditsuke

This pull request has automatically rebased to 4.2-dev.

HLeithner avatar Jun 27 '22 13:06 HLeithner

This pull request has been automatically rebased to 5.0-dev.

HLeithner avatar May 02 '23 16:05 HLeithner

Needs to updated, Call to undefined method Joomla\Component\Scheduler\Administrator\Table\TaskTable::getCurrentUser()

MacJoom avatar Aug 26 '23 13:08 MacJoom

Needs to updated, Call to undefined method Joomla\Component\Scheduler\Administrator\Table\TaskTable::getCurrentUser()

is fixed in 5.0 already, but this pr conflicts and has to be resolved

HLeithner avatar Aug 26 '23 13:08 HLeithner

This pull request has been automatically rebased to 5.1-dev.

HLeithner avatar Sep 30 '23 22:09 HLeithner

This pull request has been automatically rebased to 5.2-dev.

HLeithner avatar Apr 24 '24 09:04 HLeithner