[4.2] Finder: Allow to select which taxonomies to index

[Hackwar]

Pull Request for Issue #26233.

Summary of Changes

This allows you to set which taxonomies should be indexed by a finder plugin.

Testing Instructions

1. Setup a site with some content.
2. Disable all finder plugins except for one (to test them one by one)
3. Edit the last active finder plugin and select which taxonomies to index from the list of checkboxes.
4. Run the indexer

Actual result BEFORE applying this Pull Request

All taxonomies were indexed each time.

Expected result AFTER applying this Pull Request

Only the selected taxonomies are indexed.

[nadjak77]

I have tested this item :white_check_mark: successfully on beff9ea2382e031c01171ca7d73466f96535f4a5

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36867.}

[joomdonation]

The index behavior when the category which the item belong to is missing is inconsistent in finder plugins. In contact plugin, we stop indexing item if category not found, while in content plugin, the index process is continued

I think if category not found, we should not index the item, not depend on Category is selected to index or not. I tried to delete a category from database, the article still being indexed and searchable. However, the link to that article throws 404 error, so I don't think it is right.

Could you please check it?

[richard67]

@Hackwar Could you check the comment above https://github.com/joomla/joomla-cms/pull/36867#issuecomment-1133666716 ?

[joomla-bot]

This pull requests has been automatically converted to the PSR-12 coding standard.

[Hackwar]

I looked into this and my first reaction was to refuse a change, but @joomdonation is right here. We should not index an item if it doesn't have a category or a category can't be loaded. I changed the code accordingly. I would be really gratefull for tests to maybe still get this into 4.2?

[Quy]

I have tested this item :white_check_mark: successfully on 93dd349d353e81598111d3c53d970bc8cdc179ca

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36867.}

[carlitorweb]

I have tested this item :white_check_mark: successfully on 93dd349d353e81598111d3c53d970bc8cdc179ca

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36867.}

[richard67]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36867.}

[laoneo]

Thank you for your contribution, unfortunately the 4.4-dev branch doesn't get new features. When #40181 is merged this pr should be rebased to 5.0-dev. Thanks for understanding.

[HLeithner]

How would this look like for custom fields (in the future)? Would we add this option as custom field attribute?

[Hackwar]

#38650 adds options to set if a custom field should be indexed as text or taxonomy or none.

[richard67]

Why closed? Should we reopen the original issue?

[HLeithner]

thanks

[HLeithner]

We need documentation for this