joomla-cms icon indicating copy to clipboard operation
joomla-cms copied to clipboard

Fix tinymce when sorting happen

Open Fedik opened this issue 3 years ago • 2 comments

Pull Request for Issue #24343 .

Summary of Changes

The patch re-init an editor when the iframe moved around DOM.

Testing Instructions

Apply patch, run npm install Please follow #24343

Or create subform with editor (example in Custom HTML):

<field type="subform" name="subform" multiple="true" label="subform">
  <form>
    <field type="editor" name="text" label="editor" buttons="false"  default="I am a text!"/>
  </form>
</field>

Add couple rows in subform and try sort them. Then watch editor content.

Actual result BEFORE applying this Pull Request

Content are gone.

Expected result AFTER applying this Pull Request

Content still there (can be with little delay)

Documentation Changes Required

None

Fedik avatar Dec 18 '21 11:12 Fedik

This pull request has automatically rebased to 4.2-dev.

HLeithner avatar Jun 27 '22 13:06 HLeithner

This pull requests has been automatically converted to the PSR-12 coding standard.

joomla-bot avatar Jun 27 '22 21:06 joomla-bot

I have tested this item :white_check_mark: successfully on 1007fe6b9da12201ea789627221f5248c3b3a578


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36345.

JonasAtZwetschke avatar Jan 17 '23 12:01 JonasAtZwetschke

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36345.

Quy avatar Jan 18 '23 16:01 Quy

I have tested this item :white_check_mark: successfully on 1007fe6b9da12201ea789627221f5248c3b3a578


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36345.

Quy avatar Jan 18 '23 16:01 Quy

Thank you

roland-d avatar Jan 19 '23 10:01 roland-d

@Fedik Please check why the editor loses focus when editing an article.

Quy avatar Jan 20 '23 01:01 Quy

@Quy what wrong with focus? works fine for me

Fedik avatar Jan 20 '23 08:01 Fedik

It is reloading between editor.min.css and content.min.css. Reverting this PR fixes the issue. Using Firefox 109.0 (64-bit.

36345

36345-editor

36345-network

Quy avatar Jan 20 '23 14:01 Quy

I see, Firefox and Chrome handle iframe events diferently. I will check.

Fedik avatar Jan 21 '23 11:01 Fedik