joomla-cms
joomla-cms copied to clipboard
[4] Fix language constants overrides in com_template.inis and com_categories.ini
Pull Request for Issue https://github.com/joomla/joomla-cms/issues/35422 .
Summary of Changes
Fix language constants overrides in com_template.inis and com_categories.ini
Testing Instructions
code review
Actual result BEFORE applying this Pull Request
Original JLIB constants are used.
Expected result AFTER applying this Pull Request
Component specific constants are used
Documentation Changes Required
N/A
The change needed to be done for 3.10, but okay. However, this is wrong.
Why did you change the other constants (except for the last one in every file)?
@Kostelano Other contacts have the same issue - no component specific when using as a override.
I have tested this item :red_circle: unsuccessfully on f0586c603bd00bcea17ac78eb6945b3e6fd8bd69
This is not a valid change.
Test it (for example, create an override, install the nightly version and look at your new constants) and you can see why.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35424.
@Kostelano I removed my additional changes.
Thanks! I can't submit a test yet as I have doubts about line JLIB_RULES_SETTING_NOTES_ITEM_COM_CATEGORIES
. There should probably be a section similar to JLIB_RULES_SETTING_NOTES_ITEM_COM_CONTENT_ARTICLE.
This pull request has automatically rebased to 4.2-dev.
This pull requests has been automatically converted to the PSR-12 coding standard.
Thanks!