joomla-cms
joomla-cms copied to clipboard
Different icons for different actions.
The two different icons (such as delete and unpublish) have same icons. (i.e, $fa-var-times )
Pull Request for Issue #33432
Summary of Changes
Different icons will perform different works.
Testing Instructions
Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request
Be aware that this changes the icon used for unpublished everywhere
I think that ban symbol can also be used as to unpublish and here,disable icon works similar to unpublish.
I have tested this item :white_check_mark: successfully on 3fa2c45763fadad4126e21a93c064e87bc451cc7
I agree that the ban icon is a better option for disabled!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33515.
but is it also a good icon for an unpublished article
How about a - (minus sign) for delete?
It is not a good icon for unpublished content... it is too "negative", it makes the impression you should not touch the article any more...
@drmenzelit @brianteeman will it be ok. If changes were made on delete icon and rest of the things are remain unchanged. Something like this....

Don't know whether I am correct or not..I think it can be soved using two ways:-
i) change the delete icon to trash and rest of things remain unchanged ii) create a new icon for disable one.
I'm talking about the unpublished icon here for example:
And about trash icon for delete, please read the comment here: https://github.com/joomla/joomla-cms/issues/33432#issuecomment-830619440
My suggestion was to create an own icon class for disable
How about using the disc / circle / not default for disabled everywhere? "x" looks alwys like "forbidden"
You could use thumbs-up/thumbs-down for enable/disable. I don't think the trash can is appropriate for delete because items in trash can be recovered but items deleted are not.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33515.
thanks to facebook and youtube thumbsup/down means like/dislike to most people
In general, thumbs-up/thumbs-down shows that you are agree or approval and vice-versa with something,
toggle-on/toggle-off might work for enable/disable (but I quite like thumbs).
@chmst How about using the disc / circle / not default for disabled everywhere? "x" looks alwys like "forbidden"
If you do this, the publish icon in the dropdown should be changed to a circle with a checkmark too.
@Shubham-com i) change the delete icon to trash and rest of things remain unchanged
I like this proposal. Change the x, currently used for delete, by a trashcan
update... copied text from external chat
The problem is that trash in Joomla doesn't mean delete, something get in the trash bin and you have to empty it... delete is really delete, gone for ever... we need a new icon for it or for disable
Delete icons by FontAwesome => https://fontawesome.com/icons?d=gallery&p=2&q=delete&m=free Disable icons by FontAwesome => https://fontawesome.com/icons?d=gallery&p=2&q=disable&m=free <- not really useful I think
I agreed what the @hans2103 said, no better icon found
we can use trash icon
for those items can be recovered,which is already being used for trash.

and trash-alt icon for delete which can be used for delete forever,and it can some how differ between them.
The same issue with Extension: Manage Go to System> Manage Extension
Both Disable and Uninstall have same (X) icon.

Please don't use the different trash cans. I won't remember the purpose of each one.
Use the minus sign like in a shopping cart ... + to add an item and - to remove an item from the cart.
summary. (correct me if I'm wrong)
We need (new) icons for the following purposes
- disable / unpublish
- uninstall
- move-to-trash
my suggestions
- icon needed for disable / unpublish
- https://fontawesome.com/icons/times?style=solid
- icon needed for uninstall
- https://fontawesome.com/icons/eraser?style=solid
- https://fontawesome.com/icons/backspace?style=solid
- icon needed for move-to-trash
- https://fontawesome.com/icons/minus?style=solid
- https://fontawesome.com/icons/recycle?style=solid
I am just seeing a need for an icon for delete and an icon for uninstall
As delete and uninstall are both permanent action that can not be undone I would suggest something like https://fontawesome.com/icons/exclamation-triangle?style=solid
Thanks everyone for your suggestion, Please don't mind it.. but I still suggest trash can for delete and uninstall purposes as many of you have also seen this icon(i.e., trash can) before while uninstalling and deleting any apps or software from your device.
And for move-to trash, means that the items that can be recovered..I suggest the Recycle icon (https://fontawesome.com/icons/recycle?style=solid) the arrows in the recycle icon also indicates that them items which are moved in trash can get recovered.
I have tested this item :white_check_mark: successfully on 3fa2c45763fadad4126e21a93c064e87bc451cc7
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33515.
@sandramay0905 This PR has the "Updates Requested" label set, which means some reviewer requested changes, and since that label has been set, no change has been made, so it doesn't make much sense to test that PR now. It will not get RTC even with 2 tests as long as that review has not been clarified.
@Quy Could you check if your request is still valid?
Please also update me, what changes would you want . I got too much confused, as different suggestions from different reviewers.
This PR has the "Updates Requested" label set, which means some reviewer requested changes, and since that label has been set, no change has been made, so it doesn't make much sense to test that PR now.
Thanks for the info, @richard67, haven't know that. I'm not sure if i noticed that label in the future, grayscale is not so easy to see :-)
Can we reach a consensus on this one? @Shubham-com @brianteeman @hans2103
This pull request has automatically rebased to 4.2-dev.
This pull requests has been automatically converted to the PSR-12 coding standard.
This pull request has been automatically rebased to 5.0-dev.
I have tested this item :red_circle: unsuccessfully on 2182d8768391a30dde48236559b7713664ac30d1
Is this Issue abandoned? I tested it and it does not work - seems only relevant for backward compatibility.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33515.