joomla-cms icon indicating copy to clipboard operation
joomla-cms copied to clipboard

Different icons for different actions.

Open Shubham-com opened this issue 4 years ago • 28 comments

The two different icons (such as delete and unpublish) have same icons. (i.e, $fa-var-times )

Pull Request for Issue #33432

Summary of Changes

Different icons will perform different works.

Testing Instructions

Actual result BEFORE applying this Pull Request

Screenshot (46)

Expected result AFTER applying this Pull Request

Screenshot (45)

Shubham-com avatar May 03 '21 17:05 Shubham-com

Be aware that this changes the icon used for unpublished everywhere

brianteeman avatar May 03 '21 17:05 brianteeman

I think that ban symbol can also be used as to unpublish and here,disable icon works similar to unpublish.

Shubham-com avatar May 03 '21 17:05 Shubham-com

I have tested this item :white_check_mark: successfully on 3fa2c45763fadad4126e21a93c064e87bc451cc7

I agree that the ban icon is a better option for disabled!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33515.

RickR2H avatar May 03 '21 21:05 RickR2H

but is it also a good icon for an unpublished article

brianteeman avatar May 03 '21 21:05 brianteeman

How about a - (minus sign) for delete?

Quy avatar May 03 '21 21:05 Quy

It is not a good icon for unpublished content... it is too "negative", it makes the impression you should not touch the article any more...

drmenzelit avatar May 04 '21 06:05 drmenzelit

@drmenzelit @brianteeman will it be ok. If changes were made on delete icon and rest of the things are remain unchanged. Something like this.... Screenshot (48)

Don't know whether I am correct or not..I think it can be soved using two ways:-

i) change the delete icon to trash and rest of things remain unchanged ii) create a new icon for disable one.

Shubham-com avatar May 04 '21 08:05 Shubham-com

I'm talking about the unpublished icon here for example: grafik And about trash icon for delete, please read the comment here: https://github.com/joomla/joomla-cms/issues/33432#issuecomment-830619440

drmenzelit avatar May 04 '21 10:05 drmenzelit

My suggestion was to create an own icon class for disable

drmenzelit avatar May 04 '21 10:05 drmenzelit

How about using the disc / circle / not default for disabled everywhere? "x" looks alwys like "forbidden"

chmst avatar May 06 '21 21:05 chmst

You could use thumbs-up/thumbs-down for enable/disable. I don't think the trash can is appropriate for delete because items in trash can be recovered but items deleted are not.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33515.

ceford avatar May 09 '21 06:05 ceford

thanks to facebook and youtube thumbsup/down means like/dislike to most people

brianteeman avatar May 09 '21 07:05 brianteeman

In general, thumbs-up/thumbs-down shows that you are agree or approval and vice-versa with something,

Shubham-com avatar May 09 '21 08:05 Shubham-com

toggle-on/toggle-off might work for enable/disable (but I quite like thumbs).

ceford avatar May 09 '21 09:05 ceford

@chmst How about using the disc / circle / not default for disabled everywhere? "x" looks alwys like "forbidden"

If you do this, the publish icon in the dropdown should be changed to a circle with a checkmark too.

@Shubham-com i) change the delete icon to trash and rest of things remain unchanged

I like this proposal. Change the x, currently used for delete, by a trashcan

update... copied text from external chat

The problem is that trash in Joomla doesn't mean delete, something get in the trash bin and you have to empty it... delete is really delete, gone for ever... we need a new icon for it or for disable

Delete icons by FontAwesome => https://fontawesome.com/icons?d=gallery&p=2&q=delete&m=free Disable icons by FontAwesome => https://fontawesome.com/icons?d=gallery&p=2&q=disable&m=free <- not really useful I think

hans2103 avatar May 10 '21 19:05 hans2103

I agreed what the @hans2103 said, no better icon found we can use trash icon
Screenshot (51) for those items can be recovered,which is already being used for trash. Screenshot (50)

and trash-alt icon for delete which can be used for delete forever,and it can some how differ between them.

Shubham-com avatar May 11 '21 15:05 Shubham-com

The same issue with Extension: Manage Go to System> Manage Extension

Both Disable and Uninstall have same (X) icon. Screenshot (53)

Shubham-com avatar May 11 '21 15:05 Shubham-com

Please don't use the different trash cans. I won't remember the purpose of each one.

Use the minus sign like in a shopping cart ... + to add an item and - to remove an item from the cart.

Quy avatar May 11 '21 15:05 Quy

summary. (correct me if I'm wrong)

We need (new) icons for the following purposes

  • disable / unpublish
  • uninstall
  • move-to-trash

my suggestions

  • icon needed for disable / unpublish
    • https://fontawesome.com/icons/times?style=solid
  • icon needed for uninstall
    • https://fontawesome.com/icons/eraser?style=solid
    • https://fontawesome.com/icons/backspace?style=solid
  • icon needed for move-to-trash
    • https://fontawesome.com/icons/minus?style=solid
    • https://fontawesome.com/icons/recycle?style=solid

hans2103 avatar May 11 '21 16:05 hans2103

I am just seeing a need for an icon for delete and an icon for uninstall

As delete and uninstall are both permanent action that can not be undone I would suggest something like https://fontawesome.com/icons/exclamation-triangle?style=solid

brianteeman avatar May 11 '21 16:05 brianteeman

Thanks everyone for your suggestion, Please don't mind it.. but I still suggest trash can for delete and uninstall purposes as many of you have also seen this icon(i.e., trash can) before while uninstalling and deleting any apps or software from your device.

And for move-to trash, means that the items that can be recovered..I suggest the Recycle icon (https://fontawesome.com/icons/recycle?style=solid) the arrows in the recycle icon also indicates that them items which are moved in trash can get recovered.

Shubham-com avatar May 12 '21 14:05 Shubham-com

I have tested this item :white_check_mark: successfully on 3fa2c45763fadad4126e21a93c064e87bc451cc7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33515.

ghost avatar May 14 '21 09:05 ghost

@sandramay0905 This PR has the "Updates Requested" label set, which means some reviewer requested changes, and since that label has been set, no change has been made, so it doesn't make much sense to test that PR now. It will not get RTC even with 2 tests as long as that review has not been clarified.

@Quy Could you check if your request is still valid?

richard67 avatar May 14 '21 10:05 richard67

Please also update me, what changes would you want . I got too much confused, as different suggestions from different reviewers.

Shubham-com avatar May 14 '21 11:05 Shubham-com

This PR has the "Updates Requested" label set, which means some reviewer requested changes, and since that label has been set, no change has been made, so it doesn't make much sense to test that PR now.

Thanks for the info, @richard67, haven't know that. I'm not sure if i noticed that label in the future, grayscale is not so easy to see :-)

ghost avatar May 14 '21 11:05 ghost

Can we reach a consensus on this one? @Shubham-com @brianteeman @hans2103

drmenzelit avatar Dec 29 '21 10:12 drmenzelit

This pull request has automatically rebased to 4.2-dev.

HLeithner avatar Jun 27 '22 13:06 HLeithner

This pull requests has been automatically converted to the PSR-12 coding standard.

joomla-bot avatar Jun 27 '22 21:06 joomla-bot

This pull request has been automatically rebased to 5.0-dev.

HLeithner avatar May 02 '23 16:05 HLeithner

I have tested this item :red_circle: unsuccessfully on 2182d8768391a30dde48236559b7713664ac30d1

Is this Issue abandoned? I tested it and it does not work - seems only relevant for backward compatibility.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33515.

ceford avatar Sep 09 '23 13:09 ceford