jissues icon indicating copy to clipboard operation
jissues copied to clipboard

HTML language attribute does not get updated on multilingual pages

Open drjjw opened this issue 5 years ago • 2 comments

If you are submitting an issue for the Joomla! CMS, please submit it at https://github.com/joomla/joomla-cms/issues/new instead. You may remove this line from the issue template.

Steps to reproduce the issue

Multilingual site required. HTML language attribute will only get added for the default language and does not change on other langages.

Expected result

Eg:

<html lang="en-gb" dir="ltr">

Should become on french version of same page:

<html lang="fr-fr" dir="ltr">

but does not

Actual result

Eg:

<html lang="en-gb" dir="ltr">

remains

<html lang="en-gb" dir="ltr">

System information (as much as possible)

Joomla! 3.9.21 Tested in PHP 7.4

Additional comments

Can be fixed by changing index.php of template from:

<html lang="<?php echo $this->language; ?>" dir="<?php echo $this->direction; ?>">

to:

<html lang="<?php echo $_REQUEST['language'];?>" dir="<?= $this->direction ?>"

drjjw avatar Sep 14 '20 12:09 drjjw

@drjjw Did you notice the first line in the issue template when filling out this issue?

If you are submitting an issue for the Joomla! CMS, please submit it at https://github.com/joomla/joomla-cms/issues/new instead. You may remove this line from the issue template.

To me it seems this is exactly the case. Your issue reads to me as if it was for the CMS.

If this is the case, please do as advised. Use the link to create the issue: https://github.com/joomla/joomla-cms/issues/new.

Thanks in advance.

richard67 avatar Oct 19 '20 22:10 richard67

@drjjw P.S. And after having created the issue at the right place, close it here.

richard67 avatar Oct 19 '20 22:10 richard67