Manual icon indicating copy to clipboard operation
Manual copied to clipboard

Add removal of LegacyPropertyManagementTrait from MVC

Open Hackwar opened this issue 6 months ago • 3 comments

User description

This is the documentation PR for https://github.com/joomla/joomla-cms/pull/44907


PR Type

Documentation


Description

  • Document removal of LegacyPropertyManagementTrait from MVC classes

  • Add migration guide for deprecated set() and get() methods

  • Provide code examples for property access changes


Changes walkthrough 📝

Relevant files
Documentation
removed-backward-incompatibility.md
Document MVC trait removal migration                                         

migrations/54-60/removed-backward-incompatibility.md

  • Add new section documenting LegacyPropertyManagementTrait removal
  • Include migration examples from generic methods to direct property
    access
  • Reference related PR #44907 for implementation details
  • +15/-0   

    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • Hackwar avatar Jun 23 '25 21:06 Hackwar

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Incomplete Migration

    The migration guide doesn't address potential null property access issues when migrating from get() with default values to direct property access with null coalescing operator. Consider adding guidance for handling undefined properties.

    ```php
    // Old:
    $this->set('key', 'value');
    $var = $this->get('key', 'defaultValue');
    
    // New:
    $this->key = 'value';
    $var = $this->key ?? 'defaultValue';
    
    
    </details>
    
    </td></tr>
    </table>
    

    qodo-code-review[bot] avatar Jun 23 '25 21:06 qodo-code-review[bot]

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    qodo-code-review[bot] avatar Jun 23 '25 21:06 qodo-code-review[bot]

    seems not to be done in 6.0

    HLeithner avatar Oct 18 '25 15:10 HLeithner