github-api icon indicating copy to clipboard operation
github-api copied to clipboard

Refactoring

Open nibra opened this issue 5 years ago • 0 comments

Summary of Changes

Before this change, AbstractGithubObject::fetchUrl() altered the HTTP client on the fly to add header data. Since the header data is not part of the URL, this undocumented side effect is just wrong. Now, the options are propagated to the client in the constructor, where it should be.

Testing Instructions

See GithubObjectTest::testFetchUrlToken().

Documentation Changes Required

No.

nibra avatar Nov 29 '20 23:11 nibra