database
database copied to clipboard
joomla-framework
FIX With Mariadb 11.1.2 ordering of table is broken #290
Pull Request for Issue #290 also see https://issues.joomla.org/tracker/joomla-cms/42333
Summary of Changes
Removed public function selectRowNumber($orderBy, $orderColumnAlias) in MysqlQueryBuilder.php
it already works within DatabaseQuery.php with window function ROW_NUMBER()
Testing Instructions
see https://issues.joomla.org/tracker/joomla-cms/42333
Documentation Changes Required
only valid for Joomla 5.x because MariaDB and MySQL miniumum
Please be kind and add a test with the Mariadb 11.1.x version, see https://mariadb.com/kb/en/mariadb-11-1-3-release-notes/
This issue DOES effect Joomla 3 sites running on 11.2.2-MariaDB also.
The fix to remove the function selectRowNumber in the Joomla 3 file libraries/joomla/database/query/mysqli.php just like this PR proposes for Joomla 5
I have tested this successfully. We need this in the next Joomla Version asap.
I have tested this successfully. We need this in the next Joomla Version asap.
We can't do this change because it would break the supported mysql versions for 3.x branch.
Can you please add a version check to only use the "parent" implementation when mariadb >= 11.0 is used?
Can you please add a version check to only use the "parent" implementation when mariadb >= 11.0 is used?
I'm currently on rehabilitation and can't work on it from here. Perhaps someone else can take over. I'll be away for at least 6 weeks.
I'm currently on rehabilitation and can't work on it from here. Perhaps someone else can take over. I'll be away for at least 6 weeks.
@tkuschel My best wishes for you. I hope all will go well. Maybe @HLeithner or me can take over.
~~See also PR #308 for another alternative way to do it.~~ Closed in favour of #300 .
I have merged https://github.com/joomla-framework/database/pull/300. Thanks for providing a patch to fix the issue.
