jedchecker icon indicating copy to clipboard operation
jedchecker copied to clipboard

Published 20 hours ago • verified publisher icon joomla-extensions

Change ID of rules to match Submission Error Codes

Open dryabov opened this issue 4 years ago • 1 comments

I'd suggest to change id of PH3 rule to XM1, and INFO_XML to NM1 to match Submission Error Codes. The only negative effect is that PH3 and INFO_XML are used as a part of keys in language strings. So, either keys should be renamed in all language files, or just allow such a mismatch.

dryabov avatar Jan 31 '21 09:01 dryabov

Note: with PR#80 the INFO_XML does more than NM1-like check, so let's keep it as as. But changing PH3 to XM1 seems to be reasonable.

dryabov avatar Feb 03 '21 15:02 dryabov