Astroid-Framework icon indicating copy to clipboard operation
Astroid-Framework copied to clipboard

Notice on the new tab "custom code" in a menu item

Open ghazal opened this issue 4 years ago • 2 comments

I was checking the new tab "custom code" on a menu item (for which I really thank you). In Custom CSS File, I tried the feature "Shift order of a css file":

YOUR_CSS_FILE.css|-1 (to shift up by 1) or YOUR_CSS_FILE.css|2 (to shift down by 2)

Got a Notice:

A non well formed numeric value encountered ...

My workaround in:

libraries/astroid/framework/library/astroid/Document.php ---->line 840

Just added an integer: $newindex = $index + (int)$this->_stylesheets[$key]['shifted'];

Anyhow great addition - custom code + the possibility to shift the file up or down in head tag. Tks again.

ghazal avatar Oct 10 '20 11:10 ghazal

@hiteshaggarwal Can you check this please?

chetanmadaan avatar Oct 12 '20 15:10 chetanmadaan

Yes Sir, checked. Will merge after test.

On Mon, 12 Oct 2020 at 9:17 PM, Chetan Madaan [email protected] wrote:

@hiteshaggarwal https://github.com/hiteshaggarwal Can you check this please?

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/joomdev/Astroid-Framework/issues/193#issuecomment-707199500, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABHDAGGTEAOIG3GFQ45OX63SKMQJNANCNFSM4SLAELQA .

-- Regards Hitesh Aggarwal

hiteshaggarwal avatar Oct 12 '20 16:10 hiteshaggarwal