Astroid-Framework icon indicating copy to clipboard operation
Astroid-Framework copied to clipboard

put main menu above sticky menu in template options

Open shoulders opened this issue 5 years ago • 8 comments

These options are the wrong way around and is confusing. the main menu should always be first because it is the main menu.

image

shoulders avatar Jul 16 '19 18:07 shoulders

I think agree.

@Nishtha003 do you?

chetanmadaan avatar Jul 16 '19 20:07 chetanmadaan

@chetanmadaan agreed but we have arranged them as both the Headers first & then the Menus. @shoulders Sorry but this is the correct arrangement.

Nishtha003 avatar Jul 17 '19 04:07 Nishtha003

@shoulders

If you look at the arrangement then first is body under body we have the headers and under headers we have menus. Please see the table.

Default Suggested
Body Body
Header Header
Sticky Header Main Menu
Main Menu Sticky Header
Dropdown Menu Dropdown Menu
Off-Canvas Menu Off-Canvas Menu

itxchandan avatar Jul 17 '19 06:07 itxchandan

I am having another look at this and perhaps this where the issue is coming in.

  • header
  • Sticky Header
  • Main Menu

There is no Sticky Menu and Sticky Header has link colour/link Active/Link Hover Colour which really should be in Sticky Menu. The main menu/header is split over 2 sections so should the sticky menu/sticky header to keep the format the same.

So maybe you should have the following options to make it more logical:

New order
Body
Header
Sticky Header
Main Menu
Sticky Menu
Drop Down Menu
Off-Canvas Menu

shoulders avatar Aug 23 '19 15:08 shoulders

Thanks Jon.

@Nishtha003 @chandanndeep what do you think?

chetanmadaan avatar Aug 23 '19 15:08 chetanmadaan

@shoulders

We have Sticky Header not Sticky Menu. That's why we added those options under Sticky Header.

itxchandan avatar Aug 26 '19 11:08 itxchandan

@chandanndeep If I was going to add all of these options under one heading I would call it Sticky Menu. I have never heard of a Sticky Header but everyone knows of a Sticky Menu

A Sticky Header also implies that it does more than a menu.

I will leave this with you guys. Please feel free to close this issue if you are happy with things.

shoulders avatar Aug 27 '19 08:08 shoulders

Hi Jon,

Stick Header fits in here better since it's more than the header. It includes the background color which is not for the menu but for the whole header including the logo.

Let me know?

chetanmadaan avatar Aug 29 '19 18:08 chetanmadaan