acme-dns icon indicating copy to clipboard operation
acme-dns copied to clipboard

Spell check

Open jsoref opened this issue 4 years ago • 5 comments

This addresses #91

jsoref avatar Apr 07 '20 00:04 jsoref

Coverage Status

Coverage remained the same at 73.118% when pulling 5a773de6d69fea58d733955272328fa33fa97fa7 on jsoref:spell-check into 68bb6ab654b6fb1fe375e08807688c55621513a2 on joohoi:master.

coveralls avatar Apr 07 '20 00:04 coveralls

Thanks for the PR @jsoref , sorry it took so long to get around it. Is this still valid, and should it work as it is or does it need some additional configuration from my end?

joohoi avatar Jan 11 '21 12:01 joohoi

It's a few versions out of date (I released a 0.0.17) and I have a couple of insights to reduce the size of the expect list. But otherwise, yeah.

Lemme see if I can update this tonight/tomorrow.

It looks like 0.0.18 might come in the vaguely soon sense with a feature I've been planning for a long time, but don't wait for that.

jsoref avatar Jan 11 '21 13:01 jsoref

Ok, thanks!

joohoi avatar Jan 11 '21 13:01 joohoi

This should be good.

With this version, you get messages like: https://github.com/check-spelling/acme-dns/commit/61525b2d8e40ff713f8c9caa28bc9bb2cfedf0f8#commitcomment-45854978 -- the content of that command can be used to update the expect file fairly automatically (you can also update it manually, the file isn't particularly interesting).

I have a prototype of 0.0.18 where you can ask the bot to add a commit that applies the changes instead. But I'm want to rework it so that there's less duplicated content in the comment (right now the comment has the misspelled words twice, which is vaguely silly).

jsoref avatar Jan 11 '21 18:01 jsoref