acme-dns-certbot-joohoi icon indicating copy to clipboard operation
acme-dns-certbot-joohoi copied to clipboard

Python 2.7 EOL

Open sh511 opened this issue 5 years ago • 7 comments

Since Python 2.7 End Of Life is coming soon, any foreseen issue with the Python code in acme-dns?

sh511 avatar Nov 17 '19 18:11 sh511

The code should be completely python3 compatible, and in fact many of the distributions are running Certbot (and this) using python3 already.

joohoi avatar Nov 27 '19 09:11 joohoi

Thanks Joona. May be the documentation could mention that. At the moment it is Python 2.7.

I would also like to thank you for the software. It has been most useful to our research lab.

Sylvain

On Nov 27, 2019, at 4:50 AM, Joona Hoikkala [email protected] wrote:

The code should be completely python3 compatible, and in fact many of the distributions are running Certbot (and this) using python3 already.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/joohoi/acme-dns-certbot-joohoi/issues/14?email_source=notifications&email_token=AJXBAQY4KCFNOQU7SYSHHULQVY7GHA5CNFSM4JOLC3O2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFI536I#issuecomment-559013369, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJXBAQ5S6ZOJ767TOGTAOATQVY7GHANCNFSM4JOLC3OQ.

sh511 avatar Nov 27 '19 14:11 sh511

Thanks for you kind words. It's really encouraging to hear that the project is of use for others as well :)

Also thanks a lot for pointing out the README mention, I had completely forgotten about that, and wonder why I added it in the first place! The scripts are working and tested in Python3 as well. I fixed it in #16

joohoi avatar Nov 27 '19 14:11 joohoi

Just ended up here because the Ubuntu upgrade broke my DNS Challenge since "pythton-requests" for Python 2.7 has been removed and is a dependency.

I found a workaround but its very hacky...I hope there is an update to this soon. Workaround: move 'sys' import up a line, add in a new path before importing 'requests'...probably will blow up some time though.

import sys sys.path.append('/usr/lib/python3/dist-packages') import requests

mmiller7 avatar Jan 14 '21 20:01 mmiller7

@mmiller7 python-requests is just the ubuntu packaging of the requests package from PyPi. You can install requests for the active Python as such:

pip install requests

Depending on your operating system and environment, the active pip might be for any random installed version of Python2 or Python3. Just figure out which version of Python is invoked by Certbot/this script, and there should be a pip binary for it. Then use the fullpath to pip, which might be something like:

/usr/local/python-versions/python/3.7/bin/pip install requests
/home/user/certbot-virtualenv/bin/pip install requests

jvanasco avatar Mar 25 '21 16:03 jvanasco

alternatively, the python3 version of requests from Ubuntu is available via apt get python3-requests

leggewie avatar Nov 04 '21 22:11 leggewie