Faker.Net icon indicating copy to clipboard operation
Faker.Net copied to clipboard

New name types

Open generik0 opened this issue 7 years ago • 1 comments

Hi Because i think it is good nerding i would like to add:

  • Hitchkikers guide to the galaxy names and quotes as an extension
  • Also add nordic gods to names.

Any thoughts? will you accept the PR?

generik0 avatar Mar 15 '18 08:03 generik0

Sven,

I think you should instead consider refactoring the way names are loaded and extract all the names into a CSV file. You can then build an extension and modify Faker.net to inject an "object data source", similar to how XUnit.net supplies streams of "theory" test cases.

In this way, you can have a NamesDataSources folder and we can even extract into its own module a ton of names. We could also stratify the names into things like female first names, male first names, Norse Gods, full names of Monty Python characters and respective actors, Family Guy characters, The Simpons, etc. (I've wanted to this this for awhile to hydrate a sales demo database, as goofy names entertain people through ostensibly boring enterprise resource planning demos. :))

GitHub has a lot of projects that just host first names with gender and occurrence tags, including the famous names repository, that would allow Faker.Net to reproduce the statistical distribution of names in the US when generating names.

For the CSV loader extension, I recommend the CsvHelper or LumenWorksCsvReader (aka FastCsvReader). CsvHelper has way more downloads, mainly because LumenWorksCsvReader for years it only existed as archive file download from Sébastien Lorion's CodeProject article titled "A Fast CSV Reader". Paul Hatcher took it over and improved it a lot. CsvHelper has over 4M cumulative downloads, whereas LumenWorkersCsvReader has over 200K downloads.

jzabroski avatar Mar 15 '18 12:03 jzabroski