taco-bell-as-a-service icon indicating copy to clipboard operation
taco-bell-as-a-service copied to clipboard

Adding combos.json and adding an entry

Open ballance opened this issue 8 years ago • 5 comments

Adding updated as a date-stamp to json for all items Add some output to startup to show where the service is running

ballance avatar Aug 09 '16 13:08 ballance

+1 need combos

darethas avatar Aug 10 '16 14:08 darethas

Fantastic idea for adding the updated property. On the roadmap is full nutrition data for each item (just needs to be scraped). With that in mind, I think it would be beneficial to have the combo nutrition properties generated off of the sum of the items in the includes field. As I see it, the properties needed for combos would be name, cost, and updated. Thoughts?

jontonsoup4 avatar Aug 12 '16 03:08 jontonsoup4

Agree on pulling the combo nutrition as the sum of its taco parts. Let's go with that route. I didn't automate the scraping, but that's probably the way to go.

ballance avatar Aug 12 '16 04:08 ballance

If you add in the generation of properties for the combos, I would be happy to merge this PR

jontonsoup4 avatar Aug 13 '16 05:08 jontonsoup4

Will do.

ballance avatar Aug 15 '16 04:08 ballance