Jon Thysell
Jon Thysell
Hermes bytecode compilation fails in release mode when app is included in a separate wapproj project
Does adding "ContinueOnError" mean you're not actually using hermes bytecode? It sounds like the hermes compiler is complaining about your bundle, so my guess would be it "works" now, but...
@acoates-ms It looks like a lot of the reasons we had for forking this file are now gone (fixed upstream), can you see why this last line still needs to...
This issue seems to be related to this upstream Hermes issue: https://github.com/facebook/hermes/issues/1087. It's possible this may require getting an update into hermes-windows with this commit: https://github.com/microsoft/hermes-windows/commit/f6aed0e0fe1e106fe22a65e701e35246515f0900
It should also be noted that breakpoints are not lining up to the correct lines with any debuggers with Hermes, which should also be fixed if we integrate a newer...
If we still want to support "unpackaged" apps (as the `e2e-test-app-fabric` and `playground-composition` apps currently do) we want to make sure that's something in our control, not hacked into the...
@JunielKatarn Can you look at this? Does this seem like the right approach to adding this functionality? (See linked PR).
I have confirmed the repro for C# apps, the code crashes when trying to set up the Hermes Inspector. See if its repros with C++ apps too.
It does not repro in the C++ app with the experimental nuget, it launches and uses Hermes just fine.
Can you check if this is just in main? @YajurG Can you check in 73 / 72?
We will need this the moment we need the experimental WinAppSDK features in the Desktop builds.