single-table-inheritance

single-table-inheritance copied to clipboard

Fix: Unable to refresh a collection containing mixed types

1

Ran into an issue when trying to refresh an Eloquent collection that contains a mixture of types. The original implementation uses the first element of the collection to hydrate the...

bezhermoso

Create a test case for mutated attributes

1

These changes show a failure test case for `newFromBuilder` when an object has mutated attributes. This basically comes from using the `setRawAttributesFunction` [here](https://github.com/jonspalmer/single-table-inheritance/blob/main/src/SingleTableInheritanceTrait.php#L232) when filtering out attributes. If you used...

sarahmarshy

`newFromBuilder` does not maintain mutated attributes

2

https://github.com/jonspalmer/single-table-inheritance/blob/main/src/SingleTableInheritanceTrait.php#L188 Constructing this object with no attributes and then setting them as "filtered" does not mutate properties that are intended to be mutated. I have verified that passing the attributes...

sarahmarshy

onlyTrashed()->forceDelete() seems to lose the SingleTableInheritance scope, deletes way more than intended

2

I'm planning on working this until I have a proposed patch, but wanted to give a heads up and see if you had any advice. Here's my reproduction case in...

jwadhams

Coffellatte