parse-github-url icon indicating copy to clipboard operation
parse-github-url copied to clipboard
verified publisher icon jonschlinkert

Support adding images to slides

Open pscanf opened this issue 4 years ago • 2 comments

As discussed in https://github.com/excalideck/excalideck/discussions/6, support adding image to slides.

pscanf avatar Nov 05 '21 21:11 pscanf

👋

  • Image support was added to Excalidraw in this PR https://github.com/excalidraw/excalidraw/pull/4011
  • This feature was included in the public API as of v0.11.0 https://github.com/excalidraw/excalidraw/releases/tag/v0.11.0

I am optimistic that adding support for this will involve upgrading

https://github.com/excalideck/excalideck/blob/master/packages/excalideck-editor/package.json#L24

to

0.11.0

However, since there are breaking API changes in this release, it's possible a few more steps might be needed.

hydrosquall avatar Feb 06 '23 00:02 hydrosquall

Hey @hydrosquall. Sorry for the late reply. Yes, indeed versions after v0.11.0 have that feature. Unfortunately, as you mention, there are breaking changes in the API* which makes it not immediate to upgrade.

I have it in the back of my mind to upgrade, but unfortunately I haven't had the time/need to work on this project for a long time. (Contributions are of course welcome. 🙂 )

  • IIRC, one of the main APIs to get the drawing data becomes async - which means that all Excalideck functions using that API need to become async as well - and the format of the drawing changes slightly to support the inclusion of images.

pscanf avatar Mar 04 '23 09:03 pscanf