gray-matter icon indicating copy to clipboard operation
gray-matter copied to clipboard

feat: updating to use yaml

Open sakulstra opened this issue 2 years ago • 7 comments

use yaml instead of js-yaml as requested in #145

@jonschlinkert are you sure yaml is smaller than js-yaml (for some reason bundlephobia is broken for yaml and vscode showing bigger package size, might be wrong due to shaking though)

yaml seems to behave slightly different as you can see in the two failing tests.

sakulstra avatar Jun 23 '22 08:06 sakulstra

@jonschlinkert with #148 applied tests are passing.

sakulstra avatar Jul 10 '22 19:07 sakulstra

are you sure yaml is smaller than js-yaml (for some reason bundlephobia is broken for yaml and vscode showing bigger package size

I'm not at all sure about that lol. Thank you for doing this and for bringing it to my attention. I was initially under the impression that yaml would be smaller, since js-yaml was massively bloated the last time I checked. They included all of their tests, test fixtures, browser code, etc. in the published package. Now that you have seen both, what is your recommendation?

edit: and also, thank you for taking the time to do this, and apologies for making you jump through hoops. I promise we'll get this merged and published as soon as we settle on which library to use.

jonschlinkert avatar Jul 11 '22 15:07 jonschlinkert

Would in fact go with yaml - seems more solid to me.

sakulstra avatar Jul 11 '22 16:07 sakulstra

@jonschlinkert any chance of getting this merged? :sweat_smile:

sakulstra avatar Jul 21 '22 09:07 sakulstra

@jonschlinkert ping :sweat_smile:

sakulstra avatar Aug 23 '22 09:08 sakulstra

@jonschlinkert :crying_cat_face: - quite a lot of ppl are using this library (1M downloads per week). Would be really good if this could be merged anytime soon.

sakulstra avatar Sep 14 '22 08:09 sakulstra

@jonschlinkert ping on this, let me know if anything prevents merging.

sakulstra avatar Sep 12 '23 18:09 sakulstra