date-streaks icon indicating copy to clipboard operation
date-streaks copied to clipboard

Weekly & Monthly Streaks?

Open oyeanuj opened this issue 4 years ago • 2 comments

Hi @jonsamp, thank you for creating this excellent library!

I'm curious if you'd consider adding weekly or monthly streaks to this library at some point? I could see the summary and trackRecord method being updated to add those streaks as well.

The only other place I could find which did something similar (but now the library is unmaintained): https://github.com/iancanderson/streaker-js/blob/7f5b4c79326a803d1200bf0eb9d4718d8e149695/src/streak_calculator.coffee#L54-L92

oyeanuj avatar Dec 26 '20 18:12 oyeanuj

I like this feature idea a lot. I'm currently pretty busy with work and other projects, but happy to review a PR for this feature. Alternatively, if you could define the test cases ("x" input produces "y" output), that would help me a lot in creating the logic to accomplish this.

Sorry for the late response, thanks for opening an issue!

jonsamp avatar Feb 25 '21 06:02 jonsamp

Hi @jonsamp, thank you for creating this excellent library!

I'm curious if you'd consider adding weekly or monthly streaks to this library at some point? I could see the summary and trackRecord method being updated to add those streaks as well.

The only other place I could find which did something similar (but now the library is unmaintained): https://github.com/iancanderson/streaker-js/blob/7f5b4c79326a803d1200bf0eb9d4718d8e149695/src/streak_calculator.coffee#L54-L92

Can You give an example, for what given input you want desired output?

ghana7989 avatar Jul 19 '21 12:07 ghana7989