ud-annotatrix icon indicating copy to clipboard operation
ud-annotatrix copied to clipboard

Deleting deprels causes page change on Firefox.

Open JPJPJPOPOP opened this issue 4 years ago • 7 comments

Tested on Firefox 75, if I delete two deprels in a row, a page change will trigger to go back one page.

JPJPJPOPOP avatar May 16 '20 22:05 JPJPJPOPOP

Does this happen only when deleting them using the tree editing interface, or does it happen if editing in the textbox and/or grid mode too?

jonorthwash avatar May 18 '20 01:05 jonorthwash

Just in the tree editing interface.

JPJPJPOPOP avatar May 18 '20 01:05 JPJPJPOPOP

I'm guessing that this is because you're using Backspace to delete the deprel? If you delete one this way, the #graph widget will lose focus, and the entire window will be listening for events. In Firefox, Backspace by can be bound to "go back a page".

The most sane workaround IMO would just be to explicitly focus the #graph widget after deleting the deprel.

keggsmurph21 avatar May 31 '20 19:05 keggsmurph21

@JPJPJPOPOP can you check if bf3992b fixes this for you?

keggsmurph21 avatar May 31 '20 19:05 keggsmurph21

@keggsmurph21 I didn't, still getting the same bug.

JPJPJPOPOP avatar Jun 01 '20 07:06 JPJPJPOPOP

How are you deleting the deprel?

kmurphy4 avatar Jun 01 '20 14:06 kmurphy4

@kmurphy4 Like now if I just load the page, type up a sentence, add a deprel, then delete it, it goes back to the new tab page.

JPJPJPOPOP avatar Jun 01 '20 19:06 JPJPJPOPOP