ud-annotatrix icon indicating copy to clipboard operation
ud-annotatrix copied to clipboard

Published 20 hours ago • verified publisher icon jonorthwash

Fix of menu display (icons)

Open yaskevich opened this issue 5 years ago • 9 comments

Updating FontAwesome to up-to-date version seems to be needed

yaskevich avatar Jun 25 '19 16:06 yaskevich

Could you add a screenshot of what's broken? (The menu icons look okay for me.)

jonorthwash avatar Jun 26 '19 17:06 jonorthwash

Version from repo Annotatrix - Chromium72 Fixed in #356 Annotatrix-fixed - Chromium72

I test in Firefox and Chrome. Issues were noticed in Chromium 72.

yaskevich avatar Jun 26 '19 18:06 yaskevich

Also additional fix for Firefox (specific CORS policy adaptation) was applied, it's important for static version.

yaskevich avatar Jun 26 '19 18:06 yaskevich

The version from the repo looks fine in Firefox 60: Screenshot from 2019-06-26 23-22-05

I'd like there to be a little bit less padding on the sides (if possible).

jonorthwash avatar Jun 27 '19 03:06 jonorthwash

Reduced paddings: Annotatrix-new-menu

yaskevich avatar Jun 27 '19 16:06 yaskevich

That looks good, but I'm still confused how it was broken. It looks fine for me in Firefox (though now broken in Chromium).

jonorthwash avatar Jun 28 '19 03:06 jonorthwash

I guess it didn't get broken, it rather was untested with Chrome/Chromium, or this issue occurs only with the newest versions of Blink engine and outdated FontAwesome/Bootstrap.

yaskevich avatar Jun 28 '19 08:06 yaskevich

Ah, I see. So it became a problem when you updated Blink?

jonorthwash avatar Jun 28 '19 12:06 jonorthwash

Not exactly, I just opened it in Chromium and spotted the issue. I cannot say when it emerged.

yaskevich avatar Jul 01 '19 19:07 yaskevich