silverstripe-focuspoint icon indicating copy to clipboard operation
silverstripe-focuspoint copied to clipboard

Picker position (preview) not updated after save & publishing image (refresh needed)

Open micschk opened this issue 2 years ago • 2 comments

When a user changes the position of the focuspoint in the CMS fileSelectForm modal and then publishes the file, the UI returns to read-only mode (greyed & dimmed preview). But at this point the FP picker's position is not updated to reflect the new value (remains at its previous position).

Upon closing & reopening this modal, the picker does reflect the new FP position (so the new value gets saved correctly). Probably something to do with the "graphql context not being updated" or so...

micschk avatar Sep 11 '21 08:09 micschk

@micschk do you know if the same thing happens to other fields? Like if you change the title, is that immediately reflected in the read-only form? Just wondering if this is something that should be fixed in this module, or core.

jonom avatar Sep 16 '21 16:09 jonom

I know I see DRAFT badges all the time on things in Silverstripe that I know are published so it wouldn't be the first time something didn't get updated immediately 😅

jonom avatar Sep 16 '21 16:09 jonom

Happy to report that this doesn't happen in SS5, so closing this.

jonom avatar Feb 27 '23 23:02 jonom

Hi @jonom :)

I have just installed this package on my SS5 site. When I try to modify the focal point of my image, the picker position doesn't move. I tried to click on a corner just to see if the focal point works without the picker moving, but when I render my image via $FocusFill, it still crops it as regular. Do you have any idea why this might happen?

Screen Shot 2023-08-23 at 4 47 32 PM

palomamtnez avatar Aug 23 '23 04:08 palomamtnez