Jono Menz

Results 107 comments of Jono Menz

I think @unclecheese might have fixed this one in April 2016 https://github.com/unclecheese/silverstripe-kickassets/issues/47#issuecomment-203621622

Does appear no SVG extension is included, so you get a broken img icon in browser. Maybe should do a check to see if image icon exists and fallback to...

![screen shot 2017-04-06 at 11 45 22 am](https://cloud.githubusercontent.com/assets/1079425/24770378/98ba4db6-1abe-11e7-965b-464ec7057d81.png)

Looks like this one has been fixed and can be closed

For me, as long as there is a Delete button I can delete a folder fine. But the Delete option seems to randomly decide whether or not it will be...

I've started work on this at https://github.com/jonom/silverstripe-contentreview/commit/501d6121e5c883b758bc7005ff65856bfa17560c seems to be working well! If you guys are interested in adopting these changes let me know. It would be a breaking change,...

@robbieaverill do you agree with the changes in general? The functionality is implemented in https://github.com/jonom/silverstripe-contentreview/commit/501d6121e5c883b758bc7005ff65856bfa17560c if you want to try it out. Would need to add docs and tests but...

@michalkleiner I feel you but I think it's probably a very tough balancing act. A massive amount of work has gone in to SS4 and is still going in to...

@maxime-rainville I could be wrong but if you look at the [example](https://github.com/silverstripe/silverstripe-asset-admin/issues/765#issuecomment-497511047) I posted, I think the problem is that ~~individual components such as the UploadField re-load their own dictionary...

> That shouldn't be how it works - while components will import i18n from 'i18n' and call i18n._t(), the global dictionaries are stores on window.ss.i18n in global state @robbieaverill Yeah...