ggeasy icon indicating copy to clipboard operation
ggeasy copied to clipboard

ggbot

Open jonocarroll opened this issue 7 years ago • 3 comments

Commands currently supported:

  • change colour of points
  • remove axis, legend, everything

I also aligned the figures in the shortcuts vignette.

jonocarroll avatar Nov 11 '17 01:11 jonocarroll

I haven't added any tests yet.

jonocarroll avatar Nov 11 '17 01:11 jonocarroll

This is indeed a first start; if a proper lexer is the better way to go then I'm all for that. It looked like it wasn't too different from a bunch of if statements though. The if blocks could also be farmed out to smaller single-purpose functions for internal tersting.

jonocarroll avatar Nov 11 '17 09:11 jonocarroll

By "start" I just meant we would want to add more commands as more functionality gets added to ggeasy :smile: I think the if based approach is reasonable, and agree that as the functionality expands having smaller helper functions will be nice.

One advantage of if based approach rather than the lexer is that it would probably be more accessible for new contributors to figure out how to add new functionality, so if someone had a new helper they wanted to contribute they could also incorporate it into the bot.

AliciaSchep avatar Nov 11 '17 21:11 AliciaSchep