ggeasy icon indicating copy to clipboard operation
ggeasy copied to clipboard

Formatting y axis text would be awesome

Open smach opened this issue 5 years ago • 5 comments

Just a thought: Adding comma, dollar, or percent formatting with ggeasy would be a nice feature!

smach avatar Mar 19 '20 18:03 smach

Hi, thanks for the suggestion! Do you have an example of how to do this (the hard way) that we could target?

jonocarroll avatar Mar 19 '20 23:03 jonocarroll

If you're interested in contributing, the last PR might serve as a good guide of what is required: https://github.com/jonocarroll/ggeasy/pull/39/files

jonocarroll avatar Mar 19 '20 23:03 jonocarroll

It's scales:: scale_y_continuous(labels = comma) which isn't all that much code, just difficult to remember. And as far as I know, still requires the scales package.

I'll take a look at the code, but I'm not overly optimistic about feeling confident enough to code it myself :-)

smach avatar Mar 20 '20 00:03 smach

@jonocarroll maybe we can add a helper fn that will set up the proper code that is needed to contribute to the package. Or at least a checklist of things that need to be done in contributing.md with an example people can follow.

We did this in remedy and it gave us a common language we could converse with other users.

yonicd avatar Mar 20 '20 00:03 yonicd

@smach all good - feel free to have a crack at it if you like, no pressure, I'll help if you get stuck.

@yonicd great idea, let's work something up. I'd also like to generalise the teach code so it's easier to implement for new functions.

jonocarroll avatar Mar 20 '20 00:03 jonocarroll