two.js icon indicating copy to clipboard operation
two.js copied to clipboard

Two.Utils.read.path throws an error

Open abdallahz3 opened this issue 1 year ago • 3 comments

Describe the bug I'm trying to create a twojs path from an svg path string

To Reproduce Steps to reproduce the behavior: var d = 'M 10,30 A 20,20 0,0,1 50,30 A 20,20 0,0,1 90,30 Q 90,60 50,90 Q 10,60 10,30 z'; var heart = Two.Utils.read.path(d); two.add(heart);

trying the above code throws this error

caught TypeError: Failed to execute 'getComputedStyle' on 'Window': parameter 1 is not of type 'Element'. at Object.applySvgAttributes (

Expected behavior twojs path created from an svg path

Screenshots image

Environment (please select one):

  • [ x] Code executes in browser (e.g: using script tag to load library)
  • [ ] Packaged software (e.g: ES6 imports, react, angular, vue.js)
  • [ ] Running headless (usually Node.js)

abdallahz3 avatar Apr 18 '23 02:04 abdallahz3

Thanks for reporting. This PR fixes that issue: https://github.com/jonobr1/two.js/pull/699

jonobr1 avatar Apr 18 '23 05:04 jonobr1

that was quick, Thanks a lot @jonobr1

not sure how to test this change, I checked Versions of two.js on npm website, but don't see a new version

abdallahz3 avatar Apr 18 '23 06:04 abdallahz3

A new package isn't up, but you can npm install the git repo directly

jonobr1 avatar Apr 18 '23 21:04 jonobr1