two.js icon indicating copy to clipboard operation
two.js copied to clipboard
verified publisher icon jonobr1

[Enhancement] Code completion hint for `Two.Renderer.setSize()` method

Open cdaein opened this issue 3 years ago • 3 comments

It's not really a bug, but I am not getting code completion (VSCode IntelliSense) when using Two.Renderer.setSize() method in TypeScript.

Renderer gets completion hint: Screenshot 2023-01-06 at 2 44 40 PM

setSize doesn't: Screenshot 2023-01-06 at 2 44 52 PM

and after writing the method, no documentation appears: Screenshot 2023-01-06 at 2 45 05 PM

cdaein avatar Jan 06 '23 19:01 cdaein

Hmm, those completion hints are incorrect. Renderers don't have settings or SketchSettings. I'll take a look into this and it should be easy to add the completion hints for methods and properties to the renderers. Thanks

jonobr1 avatar Jan 07 '23 18:01 jonobr1

thanks for the reply. those settings and SketchSetting are the what I defined, so no issues with them. 🙂

cdaein avatar Jan 07 '23 19:01 cdaein

This patch should fix your issue: https://github.com/jonobr1/two.js/pull/684

jonobr1 avatar Jan 09 '23 18:01 jonobr1