chunked-request icon indicating copy to clipboard operation
chunked-request copied to clipboard

Deprecate chunked-request

Open jonnyreeves opened this issue 7 years ago • 1 comments

Appreciate that this library doesn't have many users; however as mentioned in #20, I've taken a very different approach and pulled the guts of this library out into a new package: https://github.com/jonnyreeves/fetch-readablestream/

fetch-readablestream focuses on providing cross-browser support for streaming a response using something resembling the fetch API (note: it does not implement all the methods of fetch - it's specifically just for those of us who need to stream binary data).

Factoring this logic out doesn't leave much for chunked-request to do - infact the current default chunk parser can be re-implemented in a few lines of user code, eg: https://github.com/jonnyreeves/fetch-readablestream/blob/release/v0.1.0/test/integ/util.js -- personally I am tempted to just deprecate this library and eventually remove the library from npm - but I am happy to port it / maintain it if others get use out of the API it exposes.

Thanks for your contributions @MarcusLongmuir @Ruben-Hartog @ariutta and @jimmywarting

jonnyreeves avatar Sep 21 '16 15:09 jonnyreeves

I think you're on the right track. Just be aware that NPM doesn't generally allow deleting packages anymore -- you can only deprecate.

On Sep 21, 2016 8:42 AM, "John Reeves" [email protected] wrote:

Appreciate that this library doesn't have many users; however as mentioned in #20 https://github.com/jonnyreeves/chunked-request/pull/20, I've taken a very different approach and pulled the guts of this library out into a new package: https://github.com/jonnyreeves/fetch-readablestream/

fetch-readablestream focuses on providing cross-browser support for streaming a response using something resembling the fetch API (note: it does not implement all the methods of fetch - it's specifically just for those of us who need to stream binary data).

Factoring this logic out doesn't leave much for chunked-request to do - infact the current default chunk parser can be re-implemented in a few lines of user code, eg: https://github.com/jonnyreeves/fetch- readablestream/blob/release/v0.1.0/test/integ/util.js -- personally I am tempted to just deprecate this library and eventually remove the library from npm - but I am happy to port it / maintain it if others get use out of the API it exposes.

Thanks for your contributions @MarcusLongmuir https://github.com/MarcusLongmuir @Ruben-Hartog https://github.com/Ruben-Hartog @ariutta https://github.com/ariutta and @jimmywarting https://github.com/jimmywarting

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jonnyreeves/chunked-request/issues/22, or mute the thread https://github.com/notifications/unsubscribe-auth/ABPJg4TNgqzWY7JznppSNarpzRdgV35Iks5qsVBPgaJpZM4KC9jm .

ariutta avatar Sep 23 '16 05:09 ariutta