Jonny Green comments

Results 26 comments of


                                            Jonny Green

Auth directive on Union type ignores the applyPolicy function

Good find, sounds like a bug in the way the type-level auth works - would you be up for contributing a PR?

Auth directive on Union type ignores the applyPolicy function

Completely understand, no problem at all!

Dev experience

I'll load up the website locally and report back if I think of any suggestions :)

Allow multiple roles per query.

Fantastic, thanks for posting your solution @ninnjak ! Would you be interested in contributing this example plus documentation to the repo?

Is there a way to make schema filtering work with external policy?

What error are you seeing? Are you seeing something like this? https://github.com/mercurius-js/auth/blob/main/lib/validation.js#L31 Atm, we don't support this, and to be fair this isn't called out in the docs - something...

Tests fail on the latest main for Node.js 20.x

> No clue tbh, this seems a bug between tap and Node.js. Updating this to latest tap (or to node:test`) would fix it Okay, I'll have a play! I did...

feat: make request available in context by default

Looking at the error in the CI, I think the issue is fixed in main (by this PR the other day: https://github.com/mercurius-js/mercurius/pull/1090) @adtennant Maybe worth a quick rebase and re-run...

fix: allow nullable input objects and arrays

Thanks for submitting - I'll take a look tonight :)

fix: allow nullable input objects and arrays

@mcollina thinking a semver patch release for this one?

Mercurius-codegen throw error: error TS2304: Cannot find name '_Service'.

@bkjp I think you may have opened this in the wrong repo :) Could you close this issue and reopen in the `mercurius-codegen` repo?