php-phantomjs icon indicating copy to clipboard operation
php-phantomjs copied to clipboard

Tests fail because of missing server

Open steveWinter opened this issue 5 years ago • 4 comments

I'm wanting to verify that a fork of this project is compatible with Symfony 5 prior to submitting a PR to bring this library up to date, however many of the tests fail because the server http://www.jonnyw.kiwi/ no-longer exists and so doesn't return the expected content.

I'd be happy to host the test files (and submit a PR to update the tests) if you can provide me with access to the source of the various test files?

steveWinter avatar Jan 02 '20 10:01 steveWinter

@steveWinter Did you ever make any progress on this?

alistair-soreal avatar Sep 14 '21 08:09 alistair-soreal

@alistair-soreal nope 'cause I never heard anything back on this, so I was never able to run the tests. TBH I don't now remember what I was wanting to use this library for so I'm going to close this.

steveWinter avatar Sep 14 '21 08:09 steveWinter

@alistair-soreal @steveWinter I have created a repo with the old test files if you want to fix the tests.

jonnnnyw avatar Sep 16 '21 10:09 jonnnnyw

@jonnnnyw Amazing thanks!

alistair-soreal avatar Sep 20 '21 08:09 alistair-soreal