ONIX icon indicating copy to clipboard operation
ONIX copied to clipboard

Congratulation

Open samuelgarcia opened this issue 7 years ago • 6 comments

What you have done before was super great. Here, this is totally amazing. Thank a lot.

At some point, if you need help to make a python layer over the C library I can help.

best,

Samuel

samuelgarcia avatar Nov 15 '18 09:11 samuelgarcia

Hi Thank you! For sure a python binding would be fantastic. If you want to give it a go, I'm happy to review PRs. Is there any software in particular that you want to target with a Python binding?

jonnew avatar Nov 15 '18 16:11 jonnew

I have in mind pyacq, idephyx and tridesclous. My tools to make distributed spike sorting. (GPU based at some levels)

My first step will be to bind directly the openephys USB board in python and integrate it in pyacq. I already write something about it on the mailing list. For this, I will need to bind the C++ code from intan and opalkelly.

For for this new openephys++, if I anderstand corectly you release a C library. So the python binding would be a lot easier and more efficient..

samuelgarcia avatar Nov 16 '18 07:11 samuelgarcia

Sorry for the delay. Yes, the library is located in api folder. There are already two bindings in there, C++ and C#. PRs for pythong bindings for python are welcome. You can look at how I did the C++ and C# bindings for some inspiration.

jonnew avatar Nov 26 '18 13:11 jonnew

Is it possible to open back this issue. I plan finally to make a python binding for it.

samuelgarcia avatar May 21 '20 18:05 samuelgarcia

Yep, most def. Lemme know if you have questions!

jonnew avatar May 21 '20 19:05 jonnew

I will have a look at the API when a skeleton of the dummy device will be started. It will be more easy for me. In 12 month if nothing happen you can close the PR again :)

samuelgarcia avatar May 21 '20 19:05 samuelgarcia