Username is Employee ID instead of the Employee's Name

[fiskr]

So for example, when LDAP is used to Sign Up, the LDAP employee ID (e.g. 123456) becomes the username for that new user, instead of the actual name of the employee, (e.g. "Brandon"). We can see the full name is added properly (e.g. "Foster, Brandon"), but we would like the username to be the name of the employee instead of the employee ID.

More details on the way. My intention is to submit a pull request solving this issue.

[jonmbake]

Doesn't it make sense for Employee ID to be the username since it is guaranteed to be unique? What happens if you have two users named "Brandon"?... they would have conflicting usernames. Feel free to submit a PR, but keep in mind that usernames must be unique.

[fiskr]

This is a good point, but it's certainly not intuitive that the username is a number, as likely as that is to be unique it's not a natural way to refer to a human. :-)

Maybe we could have logic that creates a username based on the first and last names, so Brandon Foster -> 'bfoster' and if there is already a 'bfoster' in the system, to create alternatives or begin to numerate the usernames. Not sure what that logic should be yet. An alternative is to make the username the full name, e.g. "BrandonFoster".