Jon Leighton

Results 51 comments of Jon Leighton

Thanks for the PR, some comments: - Have you thought about what happens if the application process gets reloaded? I.e. if you `touch config/application.rb`, when then will be the `force_ssl`...

I took a look at this the other day and realised that it needs some more fundamental changes to make it work properly. I'll come back to it at some...

@eval Sorry for the slow reply. I'll take another look.

@eval This looks good to me. Could rebase it please? Could you also document how we treat the `ENV` in the README? There are some nuances so I think it...

> Perhaps we can rescue the LoadError within the spring binstub and raise a SpringNotInstalled error, then rescue only that in the rails binstub? This sounds like a good idea...

A PR to make this configurable seems reasonable

@tigercosmos are you still working on this? If not, I'd like to take a look. I started investigating area of the code this while looking into #17321 and have drawn...

FWIW [the spec](https://drafts.csswg.org/css-fonts/#font-style-matching) leaves quite a lot of scope for the UA to decide how fallback works. Specifically, step 7: > If there are no more font families to be...

Yes, I'd still be keen to get this merged.