Jon Koops

Results 691 comments of Jon Koops

What would be logical places to use getters and setters? I think accessing a property should always be without side-effects, so the question is where are we currently using methods...

I'll re-open the issue as it seems there is still some discussion to be had :+1:

Adding this to the v2 milestone, and since this would be a breaking change I will mark it as such.

We could attempt to publish a `-dev` version to NPM on every commit although this would require some automation to create new version commits as NPM does not allow you...

I think the tarball approach would work for us, it's very low maintenance and would skip the whole actually publishing to a registry debacle.

Strange error, but no worries. If you can update the plugin file I can verify this locally.

If anything this would be an entirely separate TileLayer which I don't think is compatible with the philosophy of Leaflet (or it's current architecture). But I'd like to see one...

@spatterss135 could you rebase your work on the `main` branch?

@mourner @IvanSanchez @Falke-Design I think it's time we start prepping the 1.9 release, let's use this issue to coordinate our efforts on what we still need to do before release....

Okay, I've added all of the changes to the correct milestone. Perhaps one of you could run through it to see if I missed anything?