useref icon indicating copy to clipboard operation
useref copied to clipboard

Comments within IE conditional comments are removed

Open LionelMarbot opened this issue 9 years ago • 3 comments
trafficstars

Hi,

Do you think it could be possible to fix following issue? https://github.com/digisfera/useref/issues/35

PS: A quick workaround is to put the build tags inside the conditional comment.

Best, Lionel

LionelMarbot avatar Apr 18 '16 09:04 LionelMarbot

Can you change the title to "Comments within IE conditional comments are removed" because IE conditional comments are preserved. It's comments inside the conditional comments that are being removed. I would consider this a feature request.

jonkemp avatar Apr 18 '16 14:04 jonkemp

I agree that the current title is misleading. I will change it. However, I don't think the feature request should be about "not removing comments at all", but only about not removing <!--> when it immediately follows the opening conditional comment (e.g. <!--[if !IE]><!-->).

Removing actual comments within build tags should still be done in my opinion. What do you think?

What about "Special case of conditional comments are removed"?

LionelMarbot avatar Apr 19 '16 10:04 LionelMarbot

Just name it the same as digisfera#35.

jonkemp avatar Apr 19 '16 14:04 jonkemp